-
Notifications
You must be signed in to change notification settings - Fork 3
Add EqualsField field logic #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| import { test, expect } from '@playwright/test'; | ||
| import { addField } from './test-utils'; | ||
|
|
||
| const fieldHandle = '.tff-field-container .tff-drag-handle-icon'; | ||
|
|
||
| test('Equals(field) dropdown disabled when no other fields and excludes self', async ({ page }) => { | ||
| await page.goto(''); | ||
|
|
||
| // Set a desktop viewport | ||
| await page.setViewportSize({ width: 2048, height: 800 }); | ||
| await page.goto(''); | ||
|
|
||
| await test.step('Create an email field', async () => { | ||
| await addField(page, 'Email', undefined, { | ||
| link: 'Email', | ||
| label: 'Enter email', | ||
| }); | ||
| }); | ||
|
|
||
| await test.step('Check EqualsField disabled with no other fields', async () => { | ||
| // Reopen field settings to configure | ||
| await page.locator(fieldHandle).last().click(); | ||
| await expect(page.getByText('Email question title')).toHaveCount(1); | ||
|
|
||
| // Add field logic (field rule) | ||
| await page.getByRole('button', { name: 'Add field logic' }).click(); | ||
| const fieldRule = page.locator('.tff-field-rule').last(); | ||
|
|
||
| // EqualsField option should be disabled because there are no other fields | ||
| const equalsOption = fieldRule.locator( | ||
| 'select.tff-comparison-type option[value="EqualsField"]' | ||
| ); | ||
| await expect(equalsOption).toBeDisabled(); | ||
|
|
||
| // Remove logic | ||
| await fieldRule.locator('.tff-show-or-hide').selectOption({ index: 0 }); | ||
| await expect(fieldRule).not.toBeVisible(); | ||
|
|
||
| // Close editor | ||
| await page.locator('.tff-close-button').click(); | ||
| }); | ||
|
|
||
| await test.step('Add another email field', async () => { | ||
| await addField(page, 'Email', undefined, { | ||
| link: 'Email', | ||
| label: 'Confirm email', | ||
| }); | ||
| }); | ||
|
|
||
| await test.step('Verify EqualsField dropdown excludes self', async () => { | ||
| await page.locator(fieldHandle).last().click(); | ||
| await expect(page.getByText('Email question title')).toHaveCount(1); | ||
| await page.getByRole('button', { name: 'Add field logic' }).click(); | ||
| const fieldRule = page.locator('.tff-field-rule').last(); | ||
|
|
||
| // Add a condition and set its comparison to EqualsField | ||
| await fieldRule.locator('.tff-comparison-type').last().selectOption('EqualsField'); | ||
| await expect(fieldRule.locator('.tff-comparison-value')).toBeDisabled(); | ||
|
|
||
| // Remove logic | ||
| await fieldRule.locator('.tff-show-or-hide').selectOption({ index: 0 }); | ||
| await expect(fieldRule).not.toBeVisible(); | ||
| }); | ||
|
|
||
| await test.step('Add a field that only shows when both email fields are equal', async () => { | ||
| await addField(page, 'Single-line free text', undefined, { | ||
| link: 'Single-line free text', | ||
| label: 'Show if emails match', | ||
| description: 'Show if emails match', | ||
| }); | ||
|
|
||
| await page.locator(fieldHandle).last().click(); | ||
| await expect(page.getByText('Single-line free text question title')).toHaveCount(1); | ||
| await page.getByRole('button', { name: 'Add field logic' }).click(); | ||
| const fieldRule = page.locator('.tff-field-rule').last(); | ||
|
|
||
| const equalsOption = fieldRule.locator( | ||
| 'select.tff-comparison-type option[value="EqualsField"]' | ||
| ); | ||
| await expect(equalsOption).toBeEnabled(); | ||
| await fieldRule.locator('.tff-comparison-type').last().selectOption('EqualsField'); | ||
|
|
||
| page.locator('select.tff-text-field.tff-question-title').last().selectOption('Enter email'); | ||
| }); | ||
|
|
||
| await test.step('Verify form field logic works', async () => { | ||
| const pagePromise = page.waitForEvent('popup'); | ||
| await page.getByRole('link', { name: 'View form' }).click(); | ||
| const newPage = await pagePromise; | ||
|
|
||
| await expect(newPage.getByLabel('Enter email')).toBeVisible(); | ||
| await expect(newPage.getByLabel('Confirm email')).toBeVisible(); | ||
| await expect(newPage.getByLabel('Show if emails match')).not.toBeVisible(); | ||
|
|
||
| await newPage.getByLabel('Enter email').fill('test@example.com'); | ||
| await newPage.getByLabel('Confirm email').fill('test@example.com'); | ||
| await expect(newPage.getByLabel('Show if emails match')).toBeVisible(); | ||
| }); | ||
|
|
||
| // Close editor | ||
| await page.locator('.tff-close-button').click(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure (and _test.go didn't cover) what happens to checkboxes
Elm side is
truefor any value that is common between the two fields (intended or not)