Add EqualsField field logic #49
Conversation
✅ Deploy Preview for tiny-form-fields ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| equalsFieldDisabled = | ||
| List.isEmpty candidateFieldsExceptSelf |
There was a problem hiding this comment.
EqualsField option will be disabled if no value can be selected
disabled
enabled
| inputNode = | ||
| case comparisonOf rule of | ||
| EqualsField _ -> | ||
| -- render select of other fields (disabled if none) | ||
| if equalsFieldDisabled then | ||
| -- render a disabled text input to keep layout | ||
| input | ||
| [ type_ "text", value "", Attr.attribute "disabled" "disabled", class "tff-comparison-value" ] | ||
| [] | ||
|
|
||
| else | ||
| fieldSelectNode | ||
|
|
||
| _ -> | ||
| textInputNode |
There was a problem hiding this comment.
dropdown of other fields will be rendered if EqualsField is selected, else show a text input
There was a problem hiding this comment.
i think there's a helper function (or extract into a helper function) to render the same html structure
yongchongye
force-pushed
the
EqualsField-logic
branch
9 times, most recently
from
48c2d25 to
6b954bc
Compare
yongchongye
force-pushed
the
EqualsField-logic
branch
from
6b954bc to
dec4870
Compare
| case "EqualsField": | ||
| // the value stored in Comparison.Value is the name of another field | ||
| comparisonValue := values.Get(condition.Comparison.Value) | ||
| conditionMet = fieldValue == comparisonValue |
There was a problem hiding this comment.
i'm not sure (and _test.go didn't cover) what happens to checkboxes
Elm side is true for any value that is common between the two fields (intended or not)
| inputNode = | ||
| case comparisonOf rule of | ||
| EqualsField _ -> | ||
| -- render select of other fields (disabled if none) | ||
| if equalsFieldDisabled then | ||
| -- render a disabled text input to keep layout | ||
| input | ||
| [ type_ "text", value "", Attr.attribute "disabled" "disabled", class "tff-comparison-value" ] | ||
| [] | ||
|
|
||
| else | ||
| fieldSelectNode | ||
|
|
||
| _ -> | ||
| textInputNode |
There was a problem hiding this comment.
i think there's a helper function (or extract into a helper function) to render the same html structure
|
fixed in #50 |
2 participants
show.hide.field.when.values.are.equal.mp4
discussed with @alvinchoong and decided to add this field logic for the
confirm emailstory