Skip to content

Conversation

@cfarm
Copy link
Contributor

@cfarm cfarm commented Feb 27, 2019

This fixes https://GHE/CFGOV/platform/issues/3275 in the short term. Additional data releases in the future may cause issues with the "All" months view no longer fitting into the chart. Note that this is already the case with the small screen, "mobile" view of the bar charts- those still show false quarterly numbers with this PR.

Main changes in this are:

  1. update the repo with the latest Consumer Credit Trends data from Office of Research at https://GHE/CFPB/consumer-credit-trends-data, so that I can test the changes to the bar width
  2. update the gulp config and watch task so that the demo page automatically reloads when changes to the JS or to its html are made. previously, this was not happening - changes to scripts were processed but the demo page did not reload, and the html itself was not being watched for changes
  3. finally, edit the bar chart options to make the bars more narrow (5px) so that we can bring back the "All" time range button and view ALL monthly data at once. Previously, Highcharts was doing a tricksy thing trying to help fit all the data by combining multiple monthly data points into wider bars to make 'quarterly' numbers but the percentages it calculated were inaccurate.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cfarm cfarm changed the title Bar chart monthly not quarterly Force bar chart to show monthly data on large screens instead of faking quarterly data Mar 4, 2019
@cfarm cfarm mentioned this pull request Mar 13, 2019
@anselmbradford
Copy link
Member

@cfarm Can this be closed?

Base automatically changed from master to main February 11, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants