Conversation
|
I don't get the codecov/patch check, but it can be ignored here. |
|
Testing in Sauce at different sizes in
|
|
That last example of the screen shots of the LineChartIndex chart shows the Y axis changes from 0 to 50 as the baseline. I remember having consistent axes was a discussion early on in the Data & Research project,, but if you look at the wide variety of data and how it is reflected with different axis values across the charts now, I think that ship has already sailed. Otherwise I don't see the 'pixel shifting' issue being a problem. [review continues] |
|
|
Scotchester
left a comment
There was a problem hiding this comment.
This is all working for me localy, both standalone and in cfgov-refresh!
|
Looking at https://github.com/cfpb/cfgov-refresh/compare/upgrade_babel#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 which contains the changes described in this PR too:
these changes were made in November, before cfgov-refresh moved from npm to Yarn in February: cfpb/consumerfinance.gov#4346 I'm trying to find out if that has any implications for those changes, since it seems we need to get that branch merged in cfgov-refresh before we can merge and release this PR's changes. |
|
This open PR also upgrades babel: cfpb/consumerfinance.gov#4836 but the tests are failing. |
|
Successfully have this branch working with cfgov-refresh on the master branch - so looks like the upgrade_babel branch isn't needed for this. |




Removals
Changes
@babel/core,@babel/preset-env,autoprefixer,require-dir.Testing
./setup.sh && gulp build && gulp watchTest on cfgov-refresh
./frontend.shcfgov-refresh/node_modules/cfpb-chart-builderwithcfpb-chart-builderbase directory from this branch.gulp clean && gulp buildScreenshots
GeoMap zoom buttons are slightly different:
Before
After
LineChart tooltips now have bold values to match the bar chart tooltips:
Before
After
Whole demo page (Desktop):
Before
Desktop Before
After
Desktop After
Whole demo page (Mobile):
Before
Mobile Before
After
Mobile After
Note
ctrl+tabbetween them to see the difference. There's also some line charts that have a different rendering for the y-axis. The data is not changed, but it's presentation is shifted from this, so not sure if that matters either.Before:

After:
