-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: remove transparent variants #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ninetailedtori <ninetailedtori@uwu.gal>
sgoudham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
(I hope using Whiskers was a positive experience, we recently overhauled the documentation!)
|
Am I correct in understanding that this change was supposed to obviate the transparent variants, because the normal themes would support transparency? Looking at the edits, it seems like only I pulled this commit into my dotfiles and updated my micro settings to use |
|
You are correct - if the terminal window is transparent, then micro should be transparent as well, by default. If you're having issues, feel free to unset the bg to |
|
I have to admit I didn't read too much into the issue, we can probably re-introduce the variants but use the if check to remove the Does that solve the problem you're facing? @injust |
Just to confirm, for Catppuccin Mocha, I should be replacing |
|
Yep, that's what I'm saying to test with :) Let me know if it's fixed with that, because for me it works straight and fine with the version I pushed. What WM are you using? |
I did this and it made micro transparent again. I'm using Ghostty 1.1.3 on macOS Sequoia 15.6.1. |
|
Hmm, then we could add the check back but simply have it add the background variable if you want transparent then. I'll push a quick change for that :) |
Signed-off-by: ninetailedtori <ninetailedtori@uwu.gal>
|
@ninetailedtori #20 is already open btw. |
See #16 for details.