fix: differentiate hlsearch and selection

[ninetailedtori]

Addition of hlsearch highlighting - teal as in line with style guide.

[sgoudham]

Could you show some screenshots of how it looks like with a search and selection on the same line?

[ninetailedtori]

Could you show some screenshots of how it looks like with a search and selection on the same line?

Ah yes, lemme do that :)

Here is an example :) as you can see the highlighting is on the fg, so it's pretty subtle, and since it doesn't collide with another colour, it works quite well.

[sgoudham]

How does it look if you select "hlse" with your mouse cursor on line 4, with the hlsearch still active?

[ninetailedtori]

[ninetailedtori]

Of course, an active selection will override hlsearch and this is intended behaviour, but search already highlights the active one with selection, and that's hardcoded until it gets changed if it ever does :]

[sgoudham]

Ah, I forgot that we're probably going to want to remove color-link selection since that was added in #18.

[ninetailedtori]

Ah uh- hmm, it doesn't show up as a change in this PR, I made sure to fully rebase to the upstream before adding this commit.

[sgoudham]

No, sorry, not in this PR - just generally. Because the selection colour (surface0) is going to be quite weak and/or troublesome on the transparent variants right?

I don't use this editor so sorry if I'm getting anything wrong! Just trying to facilitate contributions as best as possible 😄

[ninetailedtori]

Ahhh, right. It's not that bad? Currently it's quite showing up for me.

[injust]

No, sorry, not in this PR - just generally. Because the selection colour (surface0) is going to be quite weak and/or troublesome on the transparent variants right?

Yup the selection is weaker on the transparent variant -- if you have a bright white window underneath, it's impossible to see.

But at the same time, removing color-link selection entirely would make the normal and transparent variants differ significantly. The default selection (bright white background) is also a bit ugly 😄

Maybe increase the opacity of the selection for the transparent variant?

[ninetailedtori]

Yee, I fixed it from that block colour previously, which it was before, super harsh and super ugly, which is why I chose this one to "mimic the transparent overlay2". It works best imo of both worlds haha.

[ninetailedtori]

Hmm I'll try choose a different overlay colour for the transparent version, gimme one sec!

[ninetailedtori]

What about this?

[injust]

surface1 looks a lot better IMO.

Screenshots

Catppuccin Mocha with Ghostty at background-opacity = 0.9. Bright white window underneath the right split.

surface0:

surface1:

[ninetailedtori]

Sounds good, then we'll keep this one? :]

[sgoudham]

If it's not too much hassle, could you try out Catppuccin Latte with these changes to make sure it looks fine too? @injust

[injust]

LGTM!

Screenshot

Catppuccin Latte with Ghostty at background-opacity = 0.9. Grey window underneath the right split.

Wow, GitHub compressed the heck out of that screenshot...

[sgoudham]

Thanks all!