Add acceptance and rest integration test#19
Merged
richardhjtan merged 3 commits intomainfrom Feb 9, 2026
Merged
Conversation
richardhjtan
force-pushed
the
acceptance-test
branch
5 times, most recently
from
48611d1 to
3a4c15b
Compare
richardhjtan
force-pushed
the
acceptance-test
branch
from
3a4c15b to
3c3a14f
Compare
richardhjtan
force-pushed
the
acceptance-test
branch
from
3c3a14f to
770a27e
Compare
tintinthong
reviewed
Feb 5, 2026
Comment on lines
+73
to
+75
| # Overwrite the test-wait-for-server script to include catalog server start | ||
| cp boxel-catalog-src/scripts/test-wait-for-servers.sh packages/host/scripts/test-wait-for-servers.sh | ||
|
|
Contributor
There was a problem hiding this comment.
why doesn't this just use the script provided?
Collaborator
Author
There was a problem hiding this comment.
In monorepo PR we remove to wait catalog realm to be ready before test.
For boxel-catalog, we should wait catalog realm ready before test hence we overwrite with this file
tintinthong
reviewed
Feb 5, 2026
|
|
||
| // CS-9919 - Skipping this test for now as the catalog realm is now setup only in | ||
| // part for speed in host tests. | ||
| skip('visiting /catalog/ renders the catalog index card', async function (assert) { |
Contributor
There was a problem hiding this comment.
we shud unskip this right
tintinthong
reviewed
Feb 5, 2026
| import { getService } from '@universal-ember/test-support'; | ||
| import { module, test } from 'qunit'; | ||
|
|
||
| import SetUserSystemCardCommand from '@cardstack/host/commands/set-user-system-card'; |
Contributor
There was a problem hiding this comment.
This test just seems like a simple command that is tapping into matrix. It doesn't depend on the system card I dont think
Collaborator
Author
There was a problem hiding this comment.
Agree. I will remain this is monorepo
richardhjtan
force-pushed
the
acceptance-test
branch
from
f1e395b to
6c34d0b
Compare
tintinthong
approved these changes
Feb 6, 2026
richardhjtan
force-pushed
the
acceptance-test
branch
4 times, most recently
from
f48b51f to
0b5096f
Compare
Collaborator
Author
|
@tintinthong I will skip a test for now because it keeps failing at CI despite it works locally. I have ticket this up |
richardhjtan
force-pushed
the
acceptance-test
branch
from
0b5096f to
fd9e24b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boxel-catalogboxel-catalogtest-wait-for-serversscript to wait CATALOG_REALM_URL to be ready, monorepo will be removed after this