Skip to content

Comments

Remove catalog tests out of monorepo#3951

Merged
richardhjtan merged 3 commits intomainfrom
CS-10119-remove-catalog-tests
Feb 10, 2026
Merged

Remove catalog tests out of monorepo#3951
richardhjtan merged 3 commits intomainfrom
CS-10119-remove-catalog-tests

Conversation

@richardhjtan
Copy link
Contributor

To be merged after this PR cardstack/boxel-catalog#19 goes in

What is changing

  • remove catalog realm involved related tests
  • skip catalog realm when doing host test
  • the SKIP_CATALOG is still needed because boxel-catalog can remove the variable and run the catalog realm test in CI
  • rename start-all-except-experiment script -> start-all-except-optional

@richardhjtan richardhjtan marked this pull request as ready for review February 5, 2026 07:24
@richardhjtan richardhjtan requested review from a team February 5, 2026 07:24
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Preview deployments

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Host Test Results

    1 files  ±  0      1 suites  ±0   1h 38m 7s ⏱️ - 9m 49s
1 788 tests  - 164  1 774 ✅  - 161  13 💤  - 4  0 ❌ ±0  1 🔥 +1 
1 803 runs   - 164  1 788 ✅  - 162  13 💤  - 4  1 ❌ +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 85917e1. ± Comparison against base commit c9cc40d.

This pull request removes 164 tests.
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "Details" button, the listing details card opens up onto the stack
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "Preview" button, the first example card opens up onto the stack
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "Remix" button, current realm (particularly catalog realm) is never displayed in realm options
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "Remix" button, the ai room is initiated, and prompt is given correctly
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "Use Skills" button, the skills is attached to the skill menu
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "carousel" area, the first example card opens up onto the stack
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: after clicking "info-section" area, the listing details card opens up onto the stack
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: carousel arrows only when multiple images exist and works when triggered
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: carousel dots appear only when multiple images exist and works when triggered
Chrome ‑ Acceptance | Catalog | catalog app tests > catalog index > listing fitted: no arrows and dots appear when one or less image exist
…

♻️ This comment has been updated with latest results.

@tintinthong
Copy link
Contributor

tintinthong commented Feb 5, 2026

@richardhjtan All test are failing. Is it still trying to fetch /catalog from test??

@richardhjtan richardhjtan force-pushed the CS-10119-remove-catalog-tests branch 8 times, most recently from fea1925 to 4e84626 Compare February 10, 2026 06:58
@richardhjtan richardhjtan force-pushed the CS-10119-remove-catalog-tests branch from 4e84626 to 2f1a5f8 Compare February 10, 2026 06:58
@richardhjtan richardhjtan force-pushed the CS-10119-remove-catalog-tests branch from 2f1a5f8 to 85917e1 Compare February 10, 2026 10:12
@richardhjtan richardhjtan merged commit f4f3793 into main Feb 10, 2026
100 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants