parse_segv.py: ignore registers with unavailable values (like pl3_ssp)#553
Open
bdrung wants to merge 1 commit intocanonical:mainfrom
Open
parse_segv.py: ignore registers with unavailable values (like pl3_ssp)#553bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 84.34% 84.36% +0.02%
==========================================
Files 104 104
Lines 20814 20823 +9
Branches 3254 3256 +2
==========================================
+ Hits 17555 17568 +13
+ Misses 2817 2814 -3
+ Partials 442 441 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hyask
approved these changes
Jan 16, 2026
Contributor
Hyask
left a comment
Hyask
left a comment
There was a problem hiding this comment.
LGTM, aside from that print that might have been forgotten.
The integration test `test_run_crash_anonymity` on Debian testing started to fail, because `ParseSegv` fails to parse the registers: ``` rax 0x0 0 rbx 0x0 0 rcx 0x555555557e08 93824992247304 rdx 0x2a 42 rsi 0x7fffffffedb8 140737488350648 rdi 0x2a 42 rbp 0x7fffffffec90 0x7fffffffec90 rsp 0x7fffffffec90 0x7fffffffec90 r8 0x7ffff7fa6680 140737353770624 r9 0x7ffff7fa7fe0 140737353777120 r10 0x7fffffffe9f0 140737488349680 r11 0x202 514 r12 0x1 1 r13 0x7ffff7ffd000 140737354125312 r14 0x7fffffffedc8 140737488350664 r15 0x555555557e08 93824992247304 rip 0x55555555513f 0x55555555513f <f+22> eflags 0x10246 [ PF ZF IF RF ] cs 0x33 51 ss 0x2b 43 ds 0x0 0 es 0x0 0 fs 0x0 0 gs 0x0 0 pl3_ssp <unavailable> fs_base 0x7ffff7d90740 140737351583552 gs_base 0x0 0 ``` So ignore registers with unavailable register values like `pl3_ssp` in this case. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
bdrung
force-pushed
the
handle-unavailable-register
branch
from
7b16031 to
75084de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test
test_run_crash_anonymityon Debian testing started to fail, becauseParseSegvfails to parse the registers:So ignore registers with unavailable register values like
pl3_sspin this case.