Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
===========================================
- Coverage 84.21% 29.08% -55.14%
===========================================
Files 104 88 -16
Lines 20778 19506 -1272
Branches 3253 2924 -329
===========================================
- Hits 17498 5673 -11825
- Misses 2827 13338 +10511
- Partials 453 495 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
force-pushed
the
unshare
branch
3 times, most recently
from
8c37db5 to
fdaf3c1
Compare
bdrung
force-pushed
the
unshare
branch
2 times, most recently
from
befa816 to
13ed286
Compare
bdrung
force-pushed
the
unshare
branch
2 times, most recently
from
9d2cd06 to
7cb51fb
Compare
Member
Author
|
Running the unshare test case in a privileged Docker container works except one issue: The namespace is the same. I'll leave it to the reader to figure out how to make it work in the container. |
Add an unshare crash test case that is a stripped down version of a crash inside a container. This test case add code coverage to the `FileNotFoundError` exception code path in `forward_crash_to_container`. See also LP #2080499.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an unshare crash test case that is a stripped down version of a crash inside a container. This test case add code coverage to the
FileNotFoundErrorexception code path inforward_crash_to_container. See also LP #2080499.This merge request depends on #484.