test: add expected_status to wait_for_gdb_child_process#513
Merged
schopin-pro merged 1 commit intocanonical:mainfrom May 28, 2025
Merged
test: add expected_status to wait_for_gdb_child_process#513schopin-pro merged 1 commit intocanonical:mainfrom
schopin-pro merged 1 commit intocanonical:mainfrom
Conversation
Rename the helper method `wait_for_gdb_sleeping_child_process` to `wait_for_gdb_child_process` and allow specifying the expected status instead of hard-coding searching for the `sleep` state. Also query the GDB child processes recursively. This change allows detecting processes that kill themselves.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 83.95% 83.94% -0.01%
==========================================
Files 101 101
Lines 20506 20506
Branches 3214 3214
==========================================
- Hits 17215 17214 -1
Misses 2843 2843
- Partials 448 449 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the helper method
wait_for_gdb_sleeping_child_processtowait_for_gdb_child_processand allow specifying the expected status instead of hard-coding searching for thesleepstate. Also query the GDB child processes recursively. This change allows detecting processes that kill themselves.This PR is split from #486 which needs more work.