`pack builder create` should support extensions #1478

natalieparellano · 2022-07-05T17:59:53Z

Summary

If a builder.toml contains [extensions] and [order-extensions]:

See Updates distribution spec for extensions spec#316 for detailed requirements

Documentation

Should this change be documented?
- Yes, see Document Dockerfiles feature (phase 1) docs#501
- No

Codecov Report

Merging #1478 (0afadda) into main (8f8cdb3) will decrease coverage by 0.14%.
The diff coverage is 80.27%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   81.12%   80.99%   -0.13%     
==========================================
  Files         155      156       +1     
  Lines       10094    10281     +187     
==========================================
+ Hits         8188     8326     +138     
- Misses       1422     1458      +36     
- Partials      484      497      +13

Flag	Coverage Δ
os_linux	`79.80% <80.27%> (-0.11%)`	⬇️
os_macos	`77.30% <80.27%> (-0.03%)`	⬇️
os_windows	`80.87% <80.27%> (-0.13%)`	⬇️
unit	`80.99% <80.27%> (-0.13%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Natalie Arellano <narellano@vmware.com>

jromero

Initial feedback:

I like the term module overall for the generic shared concept. There are still a few references where “buildpacks” are used when talking about extensions though. I think they need to be fully resolved.

ie.

BuildpackLayers
/pkg/buildpack package

pkg/buildpack/buildpack.go

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano · 2022-07-22T20:11:44Z

Still to be done:

Fix use of deprecated strings.Title
~~Test filling in extension version from the provided order for extensions~~
Ensure optional = true isn’t redundantly printed in the order for extensions
Ensure Codecov is happy
Get WCOW tests to run

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Acceptance test expects different diffIDs for Linux and Windows layers Signed-off-by: Natalie Arellano <narellano@vmware.com>

- Acceptance test expects different diffIDs for Linux and Windows layers - Fix compat Signed-off-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>

The code changed, so the diff ID changed Signed-off-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>

.github/workflows/build.yml

This will make the diff easier to parse Signed-off-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>

pkg/buildpack/buildpack.go

Signed-off-by: Natalie Arellano <narellano@vmware.com>

jjbustamante

It looks good to me

Signed-off-by: Natalie Arellano <narellano@vmware.com>

User is in active

github-actions bot added this to the 0.28.0 milestone Jul 5, 2022

github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 5, 2022

natalieparellano force-pushed the extensions-phase-1 branch from 4e4e459 to 59cc426 Compare July 5, 2022 18:05

WIP

7798d96

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the extensions-phase-1 branch from 59cc426 to 7798d96 Compare July 5, 2022 18:23

Natalie Arellano added 3 commits July 6, 2022 16:53

WIP: pack builder create "works"

48b6c4f

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Separate structs for BuildpackDescriptor and ExtensionDescriptor

85ea96e

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Remove [[stacks]] in extension.toml

dda70c2

Signed-off-by: Natalie Arellano <narellano@vmware.com>

jromero reviewed Jul 12, 2022

View reviewed changes

pkg/buildpack/buildpack.go Outdated Show resolved Hide resolved

Natalie Arellano added 15 commits July 15, 2022 12:03

Unpend pended tests

7408779

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Rename Buildpack interface to BuildModule

cfca6da

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Add validation for extensions

c393817

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Add order for extensions to /cnb/order.toml

41bb4c8

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Rename BuildpackInfo to ModuleInfo

476fc50

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Declare support for platform 0.10 (even though there is nothing to do)

9c06a20

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Rename some things

d4072a7

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Add unit tests for builder.Builder

a14a6cd

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Rename some things

5a15d01

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Rename buildpack -> thing

4355e23

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Rename pkg/buildpack to pkg/buildmodule

7183710

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Try to make BuildModule interface methods less awkward

bd37213

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Merge branch 'main' into extensions-phase-1

5119e4b

Make functions private that are not used outside the package

4611b0c

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix assertion for supported platform apis

1c46699

Signed-off-by: Natalie Arellano <narellano@vmware.com>

github-actions bot added the type/chore Issue that requests non-user facing changes. label Jul 22, 2022

Add more tests

3f152ca

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Update TODO

1e290bc

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano changed the title ~~[WIP] pack builder create should support extensions~~ pack builder create should support extensions Jul 22, 2022

natalieparellano force-pushed the extensions-phase-1 branch from 9c472ff to ce45c52 Compare September 20, 2022 17:30

Fix: ./bin/generate on LCOW should have the correct mod time

4de7a85

Acceptance test expects different diffIDs for Linux and Windows layers Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the extensions-phase-1 branch from ce45c52 to 4de7a85 Compare September 20, 2022 21:08

Fix: ./bin/generate on LCOW should have the correct mod time

77da6cc

- Acceptance test expects different diffIDs for Linux and Windows layers - Fix compat Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the extensions-phase-1 branch from 5165535 to 77da6cc Compare September 20, 2022 21:46

Natalie Arellano and others added 4 commits September 20, 2022 18:23

Fix runner IP

f24c42b

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix Windows expectation

8a62c9e

The code changed, so the diff ID changed Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix compat

c2666c0

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Merge branch 'main' into extensions-phase-1

87ea1d2

natalieparellano force-pushed the extensions-phase-1 branch from d5980cc to c9f8a54 Compare September 27, 2022 15:56

natalieparellano commented Sep 27, 2022

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

natalieparellano force-pushed the extensions-phase-1 branch 2 times, most recently from d458bf9 to d18d7da Compare September 27, 2022 16:54

Rename buildmodule back to buildpack

a3e426b

This will make the diff easier to parse Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the extensions-phase-1 branch from d18d7da to a3e426b Compare September 27, 2022 16:59

Remove TODO

7b79459

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano mentioned this pull request Oct 12, 2022

Add fixtures for testing phases 1 and 2 of Dockerfiles buildpacks/samples#128

Merged

natalieparellano mentioned this pull request Nov 8, 2022

Add support for Platform 0.10 #1547

Merged

2 tasks

jkutner reviewed Nov 10, 2022

View reviewed changes

pkg/buildpack/buildpack.go Outdated Show resolved Hide resolved

jkutner approved these changes Nov 10, 2022

View reviewed changes

Natalie Arellano added 2 commits November 10, 2022 15:54

Merge branch 'main' into extensions-phase-1

e3b2610

Add constants for buildpack and extension

a257564

Signed-off-by: Natalie Arellano <narellano@vmware.com>

jjbustamante approved these changes Nov 10, 2022

View reviewed changes

Fix lint and import cycle

0afadda

Signed-off-by: Natalie Arellano <narellano@vmware.com>

jkutner merged commit 558ae9a into main Nov 14, 2022

jkutner deleted the extensions-phase-1 branch November 14, 2022 14:30

natalieparellano mentioned this pull request Dec 2, 2022

[RFC #0066] - Pre-release APIs and experimental features buildpacks/rfcs#251

Open

6 tasks

This was referenced Dec 23, 2022

add Extensions (no DetectionOrder yet) #1580

Closed

add Extensions and Detection Order (Extensions) #1581

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`pack builder create` should support extensions #1478

`pack builder create` should support extensions #1478

Uh oh!

natalieparellano commented Jul 5, 2022 •

edited by jromero

Loading

Uh oh!

codecov bot commented Jul 5, 2022 •

edited

Loading

Uh oh!

jromero left a comment

Uh oh!

Uh oh!

natalieparellano commented Jul 22, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

jjbustamante left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pack builder create should support extensions #1478

pack builder create should support extensions #1478

Uh oh!

Conversation

natalieparellano commented Jul 5, 2022 • edited by jromero Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Documentation

Related

Uh oh!

codecov bot commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jromero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

natalieparellano commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjbustamante left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

`pack builder create` should support extensions #1478

`pack builder create` should support extensions #1478

natalieparellano commented Jul 5, 2022 •

edited by jromero

Loading

codecov bot commented Jul 5, 2022 •

edited

Loading

natalieparellano commented Jul 22, 2022 •

edited

Loading