Add fixtures for testing phases 1 and 2 of Dockerfiles #128
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
This should probably be blocked on buildpacks/pack#1478 as CI won't pass until pack has been updated to support builder creation with extensions |
|
Looks like we need to release a |
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
9fb1ec2 to
1e6dd8b
Compare
In order to create a builder with image extensions Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
1e6dd8b to
924fafb
Compare
The alpine builder contains image extensions, and we require the pull policy to be 'always' (so that we can get the manifest for the builder in the registry) Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
@AidanDelaney the pipeline is green! WDYT? |
| @@ -1,4 +1,4 @@ | |||
| PACK_FLAGS?=--pull-policy=never | |||
| PULL_POLICY_NEVER?=--pull-policy=never | |||
There was a problem hiding this comment.
I have to confess, I'm not sure why this is needed.
| build-buildpacks-alpine: build-sample-root | ||
| @echo "> Creating 'hello-moon' app using 'alpine' builder..." | ||
| $(PACK_CMD) build sample-hello-moon-app:alpine -v --builder cnbs/sample-builder:alpine --buildpack $(SAMPLES_ROOT)/buildpacks/hello-world --buildpack $(SAMPLES_ROOT)/buildpacks/hello-moon $(PACK_FLAGS) $(PACK_BUILD_FLAGS) | ||
| $(PACK_CMD) build sample-hello-moon-app:alpine -v --builder cnbs/sample-builder:alpine --buildpack $(SAMPLES_ROOT)/buildpacks/hello-world --buildpack $(SAMPLES_ROOT)/buildpacks/hello-moon $(PACK_BUILD_FLAGS) |
There was a problem hiding this comment.
Only changed the pull policy for alpine, as that's the only builder with extensions.
There was a problem hiding this comment.
AFAIK it stops pack trying to look for cnbs/sample-builder on a registry.
AidanDelaney
left a comment
AidanDelaney
left a comment
There was a problem hiding this comment.
PR provides an example where the image is switched to run-image-curl. Also demonstrates generate installing the a tree binary via apk. LGTM.
No description provided.