Propose handling of prefixes in global attrs#104
Open
jyucsiro wants to merge 2 commits intobinary-array-ld:masterfrom
Open
Propose handling of prefixes in global attrs#104jyucsiro wants to merge 2 commits intobinary-array-ld:masterfrom
jyucsiro wants to merge 2 commits intobinary-array-ld:masterfrom
Conversation
Member
marqh
reviewed
Jun 28, 2022
lib/bald/__init__.py
Outdated
|
|
||
| #add prefixes defined in global attributes | ||
| #note: this will overwrite any in prefix_list | ||
| for k in fhandle.ncattrs(): |
Member
There was a problem hiding this comment.
consider
opengeospatial/netcdf-ld#115
and only do if isPrefixedBy is not used
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users of the bald library to define a set of prefixes in netcdf global attributes. This is to accommodate the case where users are not able or willing to create a separate group or variable to contain a prefix_list. In this scenario, use of global attributes is a low barrier entry for defining prefixes.
See also opengeospatial/netcdf-ld#115