Merged
Conversation
Member
|
consider opengeospatial/netcdf-ld#115 is prefix variable a not-recommended approach? should this be implemented? |
Contributor
Author
|
A reason for not allowing encoding of prefixes in variables is that some netCDF client software treat variables as special selectors. After some thinking, I can't see an advantage of implementing it this way if we allow encoding of prefixes in globals as per opengeospatial/netcdf-ld#115 and #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a small change to include the netCDF variables in scanning for a prefix list (in addition to groups).
This is in line with Section 6.5.4
http://docs.opengeospatial.org/DRAFTS/19-002.html#_prefix_definition
"The attributes defining prefixes shall be in a separate netCDF group or variable, as attributes."
Test file: test.zip