Work around devices without end model like some SMA inverters.

[mger1]

Some devices like SMA STP10.0-3SE-40 do not have an end model and discovery fails wit an IllegalDataAddress modbus error.

Work around that by pretending an end model was found when an IllegalDataAddress error occurs during discovery and at least one valid model has been found before.

[bikeshedder]

Oh wow, what a mess!

[bikeshedder]

I cleaned up the code a bit and released 0.7.2 on crates.io including this change:

sunspec/src/client/async.rs

Lines 162 to 172 in c4a2f2c

	let [model_id, len] = match res {
	// End model found. Exit the loop.
	Ok([0xFFFF, _]) => break,
	// Some devices like SMA STP10.0-3SE-40 do not have an end model
	// and discovery fails with an IllegalDataAddress modbus error.
	// Work around that by pretending an end model was found when an
	// IllegalDataAddress error occurs during discovery and at least
	// one valid model has been found before.
	Err(ModbusError::IllegalDataAddress) if model_count > 0 => break,
	x => x,
	}?;

📦 https://crates.io/crates/sunspec/0.7.2

Thanks a lot!

[bikeshedder]

I just released sunspec 0.8.0 which updates tokio-modbus to version 0.16 and adds multi-device support. This workaround is also included:

📦 https://crates.io/crates/sunspec/0.8.0