Remove unused argument in print statement#837
Open
prestonvanloon wants to merge 1 commit intobazelbuild:masterfrom
Open
Remove unused argument in print statement#837prestonvanloon wants to merge 1 commit intobazelbuild:masterfrom
prestonvanloon wants to merge 1 commit intobazelbuild:masterfrom
Conversation
prestonvanloon
requested review from
alex1545,
nlopezgi,
rbe-toolchains-pr-bot and
smukherj1
as code owners
smukherj1
reviewed
Mar 4, 2020
| "and/or 'create_cc_configs = %s' passed as attrs") % | ||
| ( | ||
| name, | ||
| bazel_version, |
Collaborator
There was a problem hiding this comment.
I think I would instead modify this to:
print(("%s not using checked in configs; '%s' was picked/selected as a candidate matching config for Bazel %s from whose list of compatible configs are %s" +
"but it does not match " +
"the 'env = %s', 'config_repos = %s', " +
"and/or 'create_cc_configs = %s' passed as attrs") %
(
name,
config,
bazel_version,
str(bazel_compat_configs),
env,
config_repos,
create_cc_configs,
))
or something similar
smukherj1
pushed a commit
that referenced
this pull request
Aug 14, 2020
Taken suggestion from: #837 (comment) Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #836
This argument was not used. I'm not sure if it was useful so this PR proposes to remove it entirely.
I'd be happy to add to the print statement in this PR if anyone feels differently.