Fix print format args in RBE repo checked in configs validation#904
Fix print format args in RBE repo checked in configs validation#904smukherj1 merged 1 commit intobazelbuild:masterfrom greenhouse-org:fix-print-format-args
Conversation
Taken suggestion from: #837 (comment) Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
2 similar comments
|
@googlebot I signed it! |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
cc @wrowe |
|
cc @smukherj1 when you get a chance |
|
/gcbrun |
|
@smukherj1 when you get a chance looks like this is all green |
|
huh, wonder where the prow bot is gone. It should have added the "lgtm" and "approval" labels and our auto merger should have automatically picked it when once the CI was green |
Supercedes #837 as it seems to have gone stale
Taken suggestion from: #837 (comment)
We run into this as an issue when generating toolchains in a workspace with Linux and Windows toolchains, generating the Linux toolchains while there are others with checked in configs seems to hit this code and fail with:
not all arguments converted during string formatting.