Skip to content

Update formatting of prerequisites-requirements error to improve readability #11524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slawekjaranowski merged 1 commit into from
Dec 9, 2025
Merged

Update formatting of prerequisites-requirements error to improve readability #11524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impl/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public interface MavenPluginPrerequisitesChecker extends Consumer<PluginDescriptor> {
/**
*
* @param pluginDescriptor
* @param pluginDescriptor the plugin descriptor to check
* @throws IllegalStateException in case the checked prerequisites are not met
*/
@Override
Expand Down
8 changes: 3 additions & 5 deletions .../maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,11 @@ public void checkPrerequisites(PluginDescriptor pluginDescriptor) throws PluginI
if (!prerequisiteExceptions.isEmpty()) {
String messages = prerequisiteExceptions.stream()
.map(IllegalStateException::getMessage)
.collect(Collectors.joining(", "));
.collect(Collectors.joining("\n\t"));
PluginIncompatibleException pie = new PluginIncompatibleException(
pluginDescriptor.getPlugin(),
"The plugin " + pluginDescriptor.getId() + " has unmet prerequisites: " + messages,
prerequisiteExceptions.get(0));
// the first exception is added as cause, all other ones as suppressed exceptions
prerequisiteExceptions.stream().skip(1).forEach(pie::addSuppressed);
"\nThe plugin " + pluginDescriptor.getId() + " has unmet prerequisites: \n\t" + messages);
prerequisiteExceptions.forEach(pie::addSuppressed);
throw pie;
}
}
Expand Down