Skip to content

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Dec 7, 2025

Message at the end of error line is not readable ... so add some new lines and tabs to make it more readable

chery pick from ec21f4b

ref:


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski slawekjaranowski self-assigned this Dec 7, 2025
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Dec 7, 2025
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to produce different results on different platforms. It does not talk to the user or write to the console so this is not needed or desirable. Maven code should be platform independent.

…ability

Message at the end of error line is not readable ... so add some new lines and tabs to make it more readable

chery pick from ec21f4b
@slawekjaranowski
Copy link
Member Author

This PR appears to produce different results on different platforms. It does not talk to the user or write to the console so this is not needed or desirable. Maven code should be platform independent.

finally it is printed to user console ... but new lines are splitted in: MavenInvoker#logSummary or MavenCli#logSummary

@slawekjaranowski
Copy link
Member Author

@elharo I hope it is fixed also

@slawekjaranowski slawekjaranowski merged commit adaf662 into apache:master Dec 9, 2025
41 of 42 checks passed
@slawekjaranowski slawekjaranowski deleted the cp-11523 branch December 9, 2025 16:35
@github-actions github-actions bot added this to the 4.1.0 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants