Support micromatch patterns in watchman#147
Open
conartist6 wants to merge 1 commit intoamasad:masterfrom
Open
Conversation
conartist6
force-pushed
the
watchman-micromatch
branch
4 times, most recently
from
da6a865 to
ca3a88d
Compare
conartist6
force-pushed
the
watchman-micromatch
branch
from
ca3a88d to
f86cf91
Compare
Author
|
So I have two options I think. I could upgrade micromatch to v4 and use their parse API to determine if a particular glob expression is supported, or I could use glob-parse. The drawback to upgrading micromatch is that it requires node8, and as far as I can tell sane is still making an effort to support node versions far below 8. Thoughts? |
Author
|
This is now the version of the PR which would need micromatch@4. |
Collaborator
|
@conartist6 I'm good with dropping old versions of node, but all new features require some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145.