Support micromatch patterns in watchman#148
Open
conartist6 wants to merge 1 commit intoamasad:masterfrom
Open
Conversation
Author
|
The benefit of adding the dependency though is that the micromatch parser (which is actually the picomatch parser) is has some unusual structure to support certain implementation details of the library. The parse-glob parser exists only to provide a public parsing API, and is therefore also likely to be more stable from a semver perspective. Since this code only targets the node environment the weight of the additional dependency would not seem to me to be a major downside. The only worry I really have is whether there might be minor discrepancies between the behaviors of the two parsers which could cause bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential alternative to #147 which does not require micromatch@4. That comes at the cost of introducing a dependency on the
parse-globpackage, which is not the same parser that micromatch uses internally.