Skip to content

chore: bump min supported node version to 22. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santi698 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: bump min supported node version to 22. #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e3e0f
chore: bump min supported node version to 22.
santi698 Dec 8, 2025
ea295bc
chore: fix e2e test
santi698 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/_codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
build-mode: none
- language: javascript-typescript
build-mode: none
node-version: '20.x'
node-version: '24.x'
steps:
- name: Checkout repository
uses: actions/checkout@v4 # v5.0.0
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x, 24.x]

steps:
- name: Checkout code
Expand Down Expand Up @@ -60,21 +60,21 @@ jobs:
E2E_TEST_ENVIRONMENT: ${{ secrets.E2E_TEST_ENVIRONMENT }}

- name: Upload SDK test results
if: matrix.node-version == '20.x'
if: matrix.node-version == '24.x'
uses: actions/upload-artifact@v4
with:
name: test-results-sdk
path: packages/sdk/test-results/*.xml

- name: Upload CLI test results
if: matrix.node-version == '20.x'
if: matrix.node-version == '24.x'
uses: actions/upload-artifact@v4
with:
name: test-results-cli
path: packages/cli/test-results/*.xml

- name: Upload coverage to Codecov
if: matrix.node-version == '20.x'
if: matrix.node-version == '24.x'
uses: codecov/codecov-action@v3
with:
files: ./packages/sdk/coverage/lcov.info,./packages/cli/coverage/lcov.info
Expand All @@ -84,7 +84,7 @@ jobs:
fail_ci_if_error: false

- name: SonarQube Scan
if: matrix.node-version == '20.x'
if: matrix.node-version == '24.x'
uses: SonarSource/sonarqube-scan-action@v6
with:
args: >
Expand All @@ -106,7 +106,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '24.x'
cache: 'npm'

- name: Install dependencies
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '24.x'
cache: 'npm'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.18.0
v24
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .node-version file format has changed from a specific semantic version (20.18.0) to a major version with "v" prefix (v24). This is inconsistent with the previous format. Consider using either:

  • A specific version like 24.0.0 (matching the previous format)
  • Just the major version without prefix like 24

The "v" prefix format may not be compatible with all Node version managers. Most version managers like nvm and asdf support multiple formats, but consistency with the previous format would be better.

Suggested change
v24
24.0.0

Copilot uses AI. Check for mistakes.
550 changes: 253 additions & 297 deletions ATTRIBUTIONS.md
View file
Open in desktop

Large diffs are not rendered by default.

124 changes: 24 additions & 100 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@
"vitest": "^3.2.4"
},
"engines": {
"node": ">=18.0.0"
"node": ">=22.0.0"
}
}
Loading
Loading