Skip to content

Conversation

@santi698
Copy link
Collaborator

@santi698 santi698 commented Dec 8, 2025

BREAKING CHANGE: node versions 18 and 20 no longer supported

BREAKING CHANGE: node versions 18 and 20 no longer supported
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the minimum supported Node.js version from 18 to 22, marking it as a breaking change. The update removes support for Node.js versions 18 and 20, establishing Node.js 22 as the new baseline.

Key changes:

  • Updated engine requirements in package.json to require Node.js >=22.0.0
  • Modified CI/CD workflows to test against Node.js 22.x and 24.x instead of 18.x and 20.x
  • Updated .node-version file to specify v24

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated engines.node requirement from ">=18.0.0" to ">=22.0.0"
package-lock.json Regenerated lockfile with updated Node version constraints; removed obsolete nested npm dependencies for Node 18/20; added "peer": true flags to various dev dependencies
ATTRIBUTIONS.md Auto-generated reformatting of license text (no substantive changes to licensing)
.node-version Changed from specific version "20.18.0" to major version "v24"
.github/workflows/ci-cd.yml Updated test matrix to Node 22.x and 24.x; changed conditional checks and static node version references from 20.x to 24.x
.github/workflows/_codeql.yml Updated Node.js version from 20.x to 24.x for CodeQL analysis

@@ -1 +1 @@
20.18.0
v24
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .node-version file format has changed from a specific semantic version (20.18.0) to a major version with "v" prefix (v24). This is inconsistent with the previous format. Consider using either:

  • A specific version like 24.0.0 (matching the previous format)
  • Just the major version without prefix like 24

The "v" prefix format may not be compatible with all Node version managers. Most version managers like nvm and asdf support multiple formats, but consistency with the previous format would be better.

Suggested change
v24
24.0.0

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files           9        9           
  Lines        1157     1157           
  Branches      158      158           
=======================================
  Hits         1106     1106           
  Misses         51       51           
Flag Coverage Δ
unittests 95.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants