-
Notifications
You must be signed in to change notification settings - Fork 19
Standardize branch #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize branch #131
Conversation
…emplate/default. Missing app.html files added for templates
- Load all templates from templates/ directory (including default) - Check template existence under templates/ - Copy hooks.server.js from template if exists - Remove app.html handling (SvelteKit generates it)
|
|
||
| console.log(chalk.blue(`🗿 Statue SSG - Initializing '${templateName}' template...`)); | ||
|
|
||
| // 1. Copy content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have root content anymore, that's why this part(1. copy content) is removed
|
|
||
| // 3. Copy template (src + site.config.js + static + scripts) | ||
| // Always copy base files first (app.html, lib/index.css), then template overrides | ||
| fs.copySync(path.join(sourceDir, 'src/app.html'), path.join(targetDir, 'src/app.html'), { overwrite: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sveltekit already generates app.html at init
| try { | ||
| // Check if template exists before proceeding | ||
| // 'default' always exists (it's the package root) | ||
| if (templateName !== 'default') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need a condition for isDefault, since the default related files now live under the same path as the other templates.
Purpose of this pull request:
Consolidate template handling to work with the new templates/ directory structure.
(optional) Issues fixed: fixes #, fixes #
IMPORTANT - UI CHANGE DEMONSTRATION
If making a change that changes the existing UI, or adds/changes new UI elements like components, themes, or templates, you MUST include screenshots or demos/recordings of your changes:
Screenshots:
Site preview link:
Other things worth discussing regarding PR:
Anything not covered by previous sections