i18n: Replace sprintf-js with @tannin/sprintf#65273
Closed
Conversation
gziolo
added
[Type] Technical Prototype
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
There is something wrong with types so I can't use quickly CI to calculate bundle size change for
|
Member
|
I pushed a few fixes that should get this building. |
|
Size Change: -242 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Member
|
FYI @sgomes - looking at slimming down the i18n package. |
Contributor
swissspidy
reviewed
Sep 12, 2024
| "@wordpress/widgets": "file:packages/widgets", | ||
| "@wordpress/wordcount": "file:packages/wordcount" | ||
| "@wordpress/wordcount": "file:packages/wordcount", | ||
| "@tannin/sprintf": "1.2.0" |
Member
|
I'm trying to get some data on what plugins or themes might be using this, but it's tricky. Here's an attempt at searching plugins for sprintf patterns that aren't supported by tannin's sprintf. Most of the results seem to be false positives either from PHP or minified JavaScript. |
Member
|
Landed in #70434. The i18n bundle is now 37.72% smaller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Experiment for:
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast