Conversation
|
Size Change: +3.14 kB (+0.11%) Total Size: 2.99 MB
ℹ️ View Unchanged
|
5af6a6b to
4fdbd86
Compare
|
@jasmussen @WordPress/gutenberg-design This is a first iteration of #56310.
The same design doesn't work for smaller devices as the image fits to 100% width.
While icons can be avoided in touch based devices, that may not be accessible. |
|
This PR should close #37652. |
|
Great! Thank you for working on this @madhusudhand Taking a step back. Doing some brain storming. EDIT:
Add a toggle to add left/right pagination for the Expand option. So it would be something like this. Thanks! |
|
In #62762 we are moving the Link to option from the block sidebar to the block toolbar. If we make this change, will it conflict with this PR? |
|
I think we need to consider various scenarios. Here are some examples:
|
a8ca784 to
bd0700e
Compare
As per the current changes, lightbox invoked by clicking on any image except 3, and next/prev navigation moves the lightbox images between 1,2,4,5 without exiting after image 2 (on next). I would imagine this would be better experience have lightbox as single set [1,2,4,5], instead of breaking into two sets [1,2] and [3,4]. Please suggest.
@t-hamano This PR now only based on the image having "Expand to click" enabled. I don't think it will conflict. The behaviour should be same as long as the image gets the value for lightbox.
This will be
They will be skipped and it is the right thing to do, because clicking on those images directly doesn't invoke lightbox.
This is not relevant for this iteration. But #62762 makes it possible, when the setting is enabled at a gallery block level. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the detailed explanation. Since it's based only on whether the Gallery block has images with lightbox enabled, does that mean there's no way to disable navigation between images? Do we need to provide some way to disable (or enable) navigation between images? |
|
The Link to option in the Gallery block is just a global change to the With that in mind, I think there might need to be an option to explicitly enable the Gallery lightbox. For example, the UI would look like this: However, if we move the block sidebar's "Link to" control to the block toolbar in #62762, the question is whether to leave the "Enable lightbox Gallery" toggle. |
To be honest, I don't see many cases where people would want to disable image navigation. It just bothers me that there's no way to opt out of it 😅 |
I think ideally these are |
I fixed it, and it should line up correctly now.
Is this the intended behavior? I might be misunderstanding 518ba952507155eb41f40ab433db9ba7.mp4 |
|
I think that's right, though if I'm reading Hannes correctly, he's suggesting "Close [X]" instead of "[X] Close". I don't personally have an opinion on that, but perhaps a followup question: text labels are off by default, yes? (That would be my expectation) |
yes, good idea. |
|
Thank you all for your feedback. If there are no other critical issues, I plan to merge this PR in time for WordPress 7.0. |
|
I think it's worth landing. I would also love to see swipe-to-navigate on mobile, which is not a blocker for this PR, and perhaps not even feasible for 7.0. But I mention it in case a) it's trivial to add as a followup, and b) to ensure that it's not impossible to add in a followup due to the architecture. I'll trust you as developers on this. |
@jasmussen I think this is already implemented 😄 0e041e344091645076d6766145565da6.1.mp4 |
|
:whoah-emoji: Nice. Some visual sliding feedback would be a nice enhancement, so you can see yourself actually moving the images. But this is solid, thank you! |
|
Apologies for the request changes: I meant to review/approve this one, but looks like it's already green. |
|
Thank you everyone for sticking with this PR for so long. I'd like to merge this PR, but if there are any issues in the future, I will fix them before the official release of 7.0. |
* add lightbox support to gallery block * disable and hide next/prev icons based on device * remove view.js from gallery * fix a lint issue * rename isGallery to hasNavigation and imageInit method * adjust button opacity when disabled * address accessiability of lightbox navigation * fix accessibility: dynamic aria-label based on current image * Try to fix a11y issues * Improve screen reader reading * move translations to server * reset gallery_id after each gallery processing * fix php lint errors * Use block context to pass down a gallery ID * Fix frontend implementation * Fix Screen reader double reading * Don't hide lightbox when hitting Enter on prev/next buttons * Match visual order with DOM order * Do not apply opacity to focus styles on disabled prev/next buttons * Add a tooltip to navigation button * Add `cursor:pointer` to navigation buttons * Add focus trap * Add "Lightbox navigation" option * Restore aria-live/aria-atomic * Ajust z-index values * Regenerate fixtures * Fix PHP lint error * Show toggle only when lightbox.allowEditing is enabled * Fix: add data-wp-watch--inert * Remove tooltip from previous and next buttons * Enable Lightbox by default * Add some reset CSS to the navigation buttons so they aren't affected by theme styles * Fix since tag * Add control to show visible text fo three buttons * Enhance text of Enlarge button * Regenerate fixtures * Make navigation button appearance more configurable * Update fixtures * Remove aria-label attirbute if value is empty * Update help text * Simplify logic * Fix: navigationButtonType doesn't work properly when there are multiple galleries * Output aria-label only when there is no visible text * Reduce icon size when button has text * Loop through the gallery * Disable button type selection UI when there is no lightbox image * Add mobile swipe action * Tweak lightbox button style * Apply randomize order setting to lightbox images * Fix unused state * Update @SInCE docblock to 7.0.0 * Use sentence case in label * Adjust size of close and navigation buttons * Remove navigation button wrapper div * Make navigation button responsive * Aligning icons and text * Change navigation button position * Use ToggleGroupControl for navigation button type control --------- Co-authored-by: Aki Hamano <tetsuaki.hamano@gmail.com> Co-authored-by: Luis Herranz <luisherranz@gmail.com>
|
Thank you @t-hamano for the sustained work on this one |
Developed in WordPress#10968. Props ellatrix, adamsilverstein, youknowriad. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 59a08c5496008ca88f4b6b86f38838c3612d88c8..7a11a53377a95cba4d3786d71cadd4c2f0c5ac52 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Remove unnecessary block deprecation from experimental tabs (WordPress/gutenberg#75208) - Block Editor: The insertBlock(s) actions should receive the same arguments (WordPress/gutenberg#75197) - Storybook: Always load design tokens in Design System section (WordPress/gutenberg#74899) - Default all initial suggested results to 20 for navigation link ui (WordPress/gutenberg#75186) - Navigation overlay: remove experiment (WordPress/gutenberg#74968) - Move AwarenessState to @wordpress/core-data (WordPress/gutenberg#75216) - RichText: Avoid stale active formats when deleting the text (WordPress/gutenberg#75227) - Fix <CollaboratorsPresence> type imports (WordPress/gutenberg#75232) - Block Editor: Add l10n context to 'Manage allowed blocks' string (WordPress/gutenberg#75239) - Fixed: Custom colors are now reflected in the editor for heading blocks (WordPress/gutenberg#75234) - Real-time Collaboration: Fix revision restore bug (WordPress/gutenberg#75233) - Real-time collaboration: Update 'sync.providers' filter inline comments (WordPress/gutenberg#75248) - Real-time collaboration: Make the collaborators presense button translatable (WordPress/gutenberg#75252) - Fix: Navigation Overlay Close Block: Add missing @SInCE tag WordPress/gutenberg#75247 (WordPress/gutenberg#75250) - Cover: Add new "fullheight" icon, and use for Cover (WordPress/gutenberg#75240) - Real-time collaboration: Remove @wordpress/sync from bundled packages and add private APIs (WordPress/gutenberg#74671) - Navigation Link: Clarify Link To invalid and draft state messages (WordPress/gutenberg#74054) - Docs: Simplifying Gutenberg versions table (WordPress/gutenberg#75209) - UI: Remove Box component abstraction (WordPress/gutenberg#74986) - Docs: Remove private GitHub team links in repository management (WordPress/gutenberg#75255) - UI: Add `Textarea` primitive (WordPress/gutenberg#74707) - Components: Add usage guidance for agents and Storybook (WordPress/gutenberg#74815) - Theme: Update elevation tokens to use abbreviated size names (WordPress/gutenberg#75103) - Navigation link: fix resetting link from the tools panel (WordPress/gutenberg#75228) - List View Support: Only render list view on top level block with support (WordPress/gutenberg#75166) - Gallery: Add lightbox support (WordPress/gutenberg#62906) - Workflows: Ignore icons manifest for manual backports (WordPress/gutenberg#75245) - Add new `adaptiveSelect` DataForm control (WordPress/gutenberg#74937) - Site Editor Pages: QuickEdit as a modal (WordPress/gutenberg#75173) - Add block rename keyboard shortcut (WordPress/gutenberg#74454) - Playlist block: Remove border (WordPress/gutenberg#75202) - Widget Area: Disable renaming and visibility support (WordPress/gutenberg#75279) - @wordpress/theme: add missing CHANGELOG entries (WordPress/gutenberg#75281) - Storybook: Add Stories for LetterSpacingControl component (WordPress/gutenberg#73480) - Remove the client from the awareness state when they disconnect (WordPress/gutenberg#75253) - Fix awareness timeout documentation unit (WordPress/gutenberg#75284) - Add global setting to enable real-time collaboration (WordPress/gutenberg#75286) - Notes: Pressing Escape should cancel adding a note (WordPress/gutenberg#75288) - Real-time Collaboration: Change users to collaborators (WordPress/gutenberg#75237) - Add timestamp when publishing next versions (WordPress/gutenberg#75293) - Storybook: Preserve export order for stories (WordPress/gutenberg#75295) - ToggleControl: Prevent console warning for `__nextHasNoMarginBottom` (WordPress/gutenberg#75296) - Quick edit: Make footer sticky (WordPress/gutenberg#75297) - DataForm Regular layout: label always uppercase (WordPress/gutenberg#75292) - @wordpress/ui: add Dialog component (WordPress/gutenberg#75183) - Navigation Link: Go to page link and edit page for inspector sidebar (WordPress/gutenberg#75262) - SiteEditor Pages: prevent QuickEdit modal from being triggered in list layout via URL param (WordPress/gutenberg#75300) - Link Control: Fix validation timing (WordPress/gutenberg#75267) - Publishing packages: fix next timestamp (WordPress/gutenberg#75301) - Add storybook for ColorPaletteControl (WordPress/gutenberg#74425) - Post Comments Form: Migrate to text-align block support (WordPress/gutenberg#75322) - Post Comments Count: Migrate to text-align block support (WordPress/gutenberg#75321) - Optimize tabsList computation with useRef for comparison (WordPress/gutenberg#75219) - Accordion block: Add list view support (WordPress/gutenberg#75271) - Media Fields: Filter author field to only show users with authoring capabilities (WordPress/gutenberg#75328) - Fields: Fix `authorField` query (WordPress/gutenberg#75298) - Slot: fix ref forwarding (WordPress/gutenberg#75274) - wp-env: Add --config option for custom config files (WordPress/gutenberg#75087) - Update Emotion for React 19 compat (WordPress/gutenberg#75324) - Block Visibility: Show keyboard shortcut hint in context menu (WordPress/gutenberg#75334) - Updated Typo in template-activate file (WordPress/gutenberg#75333) - wp-env: fix status command (WordPress/gutenberg#75325) - Playlist block:Inherit more CSS (WordPress/gutenberg#75256) - DataViews: Add onReset prop for view persistence reset (WordPress/gutenberg#75093) - Notes: Add a keyboard shortcut for creating a new note (WordPress/gutenberg#75287) - Storybook: Fix missing props on certain components (WordPress/gutenberg#75316) - Pattern Editing: Allow click through to List View (WordPress/gutenberg#75246) - Block Bindings: Have block fields panel reflects bound attribute value (WordPress/gutenberg#72096) - Fix: ISO 8601 compliant year formatting in TimePicker (WordPress/gutenberg#75343) - Prevent fatal error when the inline CSS duotone variable is an array (WordPress/gutenberg#75283) - Bugfix: Set the removed users to empty for awareness (WordPress/gutenberg#75337) - Button: prevent outline flicker when focused and active at the same time (WordPress/gutenberg#75346) - Real-time collaboration: Always target autosave revision (WordPress/gutenberg#75105) - In-editor revisions: add visual diffing (WordPress/gutenberg#75049) - iAPI Router: Update cached styles for re-fetched pages (WordPress/gutenberg#75097) - Add tests for the awareness code in core-data (WordPress/gutenberg#75074) - Add tests for the awareness code in sync (WordPress/gutenberg#75077) - Lock save button during Client Side Media processing and uploading (WordPress/gutenberg#74951) - Real-time Collaboration: Fix broken unit tests for awareness (WordPress/gutenberg#75362) - Boot: Fix mobile admin bar covering single-page mode headers (WordPress/gutenberg#75339) - Design System: Add guidelines for save and submit UX (WordPress/gutenberg#74811) - Featured Image: fix select-default-value (WordPress/gutenberg#75358) - Breadcrumbs: Improve loading state rendering (WordPress/gutenberg#75383) - Block Editor: Remove formatting controls restriction private API (WordPress/gutenberg#75382) - Link Control: Validate on submit (WordPress/gutenberg#75310) - Rich Text: Remove min-width inline style causing flex layout issues (WordPress/gutenberg#75370) - Tabs: Tidy up UI for controls (WordPress/gutenberg#75309) - Core Block Reference: Fix object empty inner key processing (WordPress/gutenberg#75391) - Improve sync performance metrics (WordPress/gutenberg#75029) - DataForm: update panel trigger (WordPress/gutenberg#75290) - Block Editor: Fix Columns block horizontal spacing when setting vertical gap (WordPress/gutenberg#75355) - DataViews Filters: Fix styling of long values in filter dropdown (WordPress/gutenberg#75369) - Try swapping tabs (WordPress/gutenberg#75194) - RichText: move useFormatTypes to rich-text package (WordPress/gutenberg#75387) - Make all navigation overlay close buttons work (WordPress/gutenberg#75384) - Block Editor: Improve Background panel UI in Global Styles (WordPress/gutenberg#75230) - Tabs: Update Tabs block icons (WordPress/gutenberg#75376) - Accordion: Move Accordion icons to Icon library (WordPress/gutenberg#75380) - Fix: Changing URL in link after changing text outside the popover resets it (WordPress/gutenberg#75342) - Update icon manifest acronyms. (WordPress/gutenberg#75418) - Code Modernization: Use null coalescing operator in additional `isset() ternaries. (WordPress/gutenberg#75419) - Pattern Editing: Move List View selectors to private-selectors (WordPress/gutenberg#75414) - DataViews: Use public ColorPicker instead of internal Picker export (WordPress/gutenberg#75394) - Abilities: Allow nested namespace ability names (2-4 segments) (WordPress/gutenberg#75393) - Fix: Remove backport changelog committed by mistake (WordPress/gutenberg#75441) - Block Visibility: Simplify toolbar for hidden blocks (WordPress/gutenberg#75335) - Block Visibility: Centralize modal state in block-editor store (WordPress/gutenberg#75367) - Allow grid to use style variation blockGap values for columns calculation (WordPress/gutenberg#75360) - Langauge Format: Add missing attribute definiton (WordPress/gutenberg#75422) - Block transform command: pass the block icon src rather than a BlockIcon component (WordPress/gutenberg#75365) - Note: Remove block highlight when deleting parent note (WordPress/gutenberg#75453) - Core Data: Improve blocks cache in useEntityBlockEditor (WordPress/gutenberg#75400) - MediaEdit: Support ordered values and reordering of items (WordPress/gutenberg#75207) - Writing flow: fix select all with full formatting (WordPress/gutenberg#64934) - Filter navigation category patterns to only show in navigation-overlay template part context (WordPress/gutenberg#75276) - Update Testing Library for React 19 compat (WordPress/gutenberg#75340) - Writing Flow: Fix block selection from partially selected RichText (WordPress/gutenberg#75449) - Notes: Fix sidebar display logic for small screens (WordPress/gutenberg#75454) - Post editor: iframe: check inserted rather than registered block versions (WordPress/gutenberg#75187) - Block Visibility: Disable visibility toggle for children of sections (WordPress/gutenberg#75447) - Notes: Update shortcut category (WordPress/gutenberg#75461) - Add dedicated navigation-overlay icon (WordPress/gutenberg#75249) (WordPress/gutenberg#75426) - Docs: Rename Interactivity API's 'API Reference' to 'Directives and Store' (WordPress/gutenberg#74974) - DataForm: Fix color picker styles (WordPress/gutenberg#75427) - Post Excerpt Block: Remove REST API filter for excerpt length in post excerpt block (WordPress/gutenberg#75299) - Move experimental PR out of backport log (WordPress/gutenberg#75465) - Add paste logging to writing flow (WordPress/gutenberg#73885) - Real-time collaboration: Sync post content and undefined `blocks` value (WordPress/gutenberg#75437) - Gutenberg plugin: always enforce the iframe in the post editor (WordPress/gutenberg#75475) - New Block: Icon Block (WordPress/gutenberg#71227) - Tabs: Improve tab keyboard nav (WordPress/gutenberg#75471) - Pre-populate Navigation Page Creator with Search Text (WordPress/gutenberg#75154) - Block Library: Hide navigation-overlay template parts from inserter (WordPress/gutenberg#75478) - Tabs: Add text and background color support (WordPress/gutenberg#75482) - Preserve existing URLInput defaults (WordPress/gutenberg#75392) - UI: Remove unnecessary jest.setTimeout from Select test (WordPress/gutenberg#75444) - Fix missed dimension token migration in UI package (WordPress/gutenberg#75446) - Render default density selector last in design tokens CSS (WordPress/gutenberg#75474) - Navigation: Improved help text in create a page flow (WordPress/gutenberg#75349) - Fix gap token migration guide in changelog (WordPress/gutenberg#75492) - Block Visibility: Disable Apply button on non-dirty state (WordPress/gutenberg#75494) - Real-time Collaboration: Use Y.text for title, content and excerpt (WordPress/gutenberg#75448) - DataForm: Style SummaryButton in panel layout with `is-disabled` classname (WordPress/gutenberg#75470) - Gallery: Add list view block support (WordPress/gutenberg#75407) - Types: consistently use the React namespace (WordPress/gutenberg#75499) - Enhance block appender labels to reflect default block type (WordPress/gutenberg#71502) - Import Yjs correctly (WordPress/gutenberg#75500) - Add testsEnvironment option and split Gutenberg wp-env configs (WordPress/gutenberg#75341) - Add `clearEntityRecordEdits` action to core-data (WordPress/gutenberg#75397) - Tabs: Stabilize Tabs blocks (WordPress/gutenberg#75424) - Simplify Tabs Menu Item editing (WordPress/gutenberg#75416) - Fix LinkControl URL Normalization (WordPress/gutenberg#75488) - Navigation Submenu: Restore openSubmenusOnClick to usesContext for backward compatibility. (WordPress/gutenberg#75435) - Tabs: Add `@since 7.0.0` annotations (WordPress/gutenberg#75521) - Story types: fix StoryFns used as React components (WordPress/gutenberg#75472) - Tabs: fix incorrect fixtures (WordPress/gutenberg#75523) - AGENTS.md: Add CLAUDE.md symlinks, architecture decisions, and common pitfalls (WordPress/gutenberg#75507) - Use contextual snackbar text when activating a theme from preview (WordPress/gutenberg#75385) - Pick user fields instead of spreading the entire object (WordPress/gutenberg#75528) - Real-time collaboration: Move PHP code to compat / backports directory (WordPress/gutenberg#75366) - Icons: Fix incorrect attributes for SVG (WordPress/gutenberg#75273) - Icons: Make full height icon label title case (WordPress/gutenberg#75524) - Respect deprecated openSubmenusOnClick value on frontend rendering (WordPress/gutenberg#75439) - useRef: always supply initial value (WordPress/gutenberg#75513) - Code Modernization: Replace isset() checks with null coalescing operator (WordPress/gutenberg#75425) - Prefix usages of JSX namespaces with React.JSX (WordPress/gutenberg#75508) - Cleanup: Remove unnecessary array check in `WP_Theme_JSON_Gutenberg` (WordPress/gutenberg#75515) - Real-time collaboration: Add collaborators cursor awareness (WordPress/gutenberg#75398) - Post Comments Link: Migrate to Text-Align Block Support (WordPress/gutenberg#75332) - Post time to read: Migrate to Text-Align Block Support (WordPress/gutenberg#75541) - ExternalLink: Prevent Twemoji from replacing arrow (WordPress/gutenberg#75538) - Duotone: add sgomes as owner (WordPress/gutenberg#75519) - Use null coalescing operator for common isset patterns (WordPress/gutenberg#75487) - Term Description: Migrate to Text-Align Block Support (WordPress/gutenberg#75542) - Create sub-sized images (WordPress/gutenberg#74566) - Add EXIF metadata tests for Client Side Media (WordPress/gutenberg#74909) - Add AVIF, WebP and MozJPEG output encoding support (WordPress/gutenberg#75081) - Post Terms: Migrate to Text-Align Block Support (WordPress/gutenberg#75545) - Tabs: Make Example preview translatable (WordPress/gutenberg#75555) - List View tab: Ensure it's populated when first selecting a container block (WordPress/gutenberg#75558) - Fix auto draft bug for Y.text titles (WordPress/gutenberg#75560) - Border Support: Fix editor split border style fallback (WordPress/gutenberg#75546) - Block Editor: Avoid unnecessary state churn in controlled inner blocks reducers (WordPress/gutenberg#75458) - Block Lock: Disable Apply button on non-dirty state (WordPress/gutenberg#75495) - Post Terms: Avoid unbound queries when the post context isn't available (WordPress/gutenberg#75536) - wp-env Playground: improve mapping and core source handling (WordPress/gutenberg#75527) - DataForm: add edit variant (WordPress/gutenberg#75462) - Tabs: Improve Tab Panel accessibility (WordPress/gutenberg#75484) - Tabs: Remove name editing UI (WordPress/gutenberg#75554) - useBlockSync: stop reconstructing controlled inner blocks (WordPress/gutenberg#75562) - Notes: Fix new note creation from the List View (WordPress/gutenberg#75566) - Navigation: Update overlay template part naming to "Navigation Overlay" (WordPress/gutenberg#75564) - Update usage of RefObject types (React 19 compat) (WordPress/gutenberg#75567) - useMergeRefs: migrate to TypeScript (WordPress/gutenberg#75569) - Improve link preview badges (WordPress/gutenberg#75318) - Add getDimensionsClassesAndStyles function and related tests (WordPress/gutenberg#74524) - Informational Parity between Inspector Link Preview and on Canvas Link Preview (WordPress/gutenberg#75399) - Icons Registry: Don't expose "internal" icons (WordPress/gutenberg#75526) - ui/Button: fix disabled styles and variable composition (WordPress/gutenberg#75568) - Tabs: Set explicit font-family on tab buttons (WordPress/gutenberg#75537) - Interactivity API: Export `watch` from `@preact/signals`'s `effect` (WordPress/gutenberg#75563) - iAPI router: Move internal properties to a private store (WordPress/gutenberg#70882) - Post Excerpt: Add text columns support (WordPress/gutenberg#75587) - Update gutenberg to match core after WordPress/gutenberg#75360 sync (WordPress/gutenberg#75594) - Block Visibility: Show viewport icons and tooltip in list view for hidden blocks (WordPress/gutenberg#75404) - [Real-time collaboration] Refine collaborator overlay with Avatar component integration (WordPress/gutenberg#75595) - Media Utils: Auto-select uploaded files in media modal experiment (WordPress/gutenberg#75597) - Try enabling paragraphs to be added to contentOnly patterns (WordPress/gutenberg#73222) - Implement WebAssembly support detection and fallbacks (WordPress/gutenberg#74827) - Icon block: Skip serialization and increase default size (WordPress/gutenberg#75553) - In-editor Revisions: Update success notice message (WordPress/gutenberg#75411) - Stabilize PHP-Only Block Registration (WordPress/gutenberg#75543) - Add comments around expandRevision functionality (WordPress/gutenberg#75573) - Tab Block: Ensure label formatting works correctly (WordPress/gutenberg#75548) - Tabs: Fix saved HTML (WordPress/gutenberg#75580) - [Real-time collaboration] Fix <CollaboratorsPresence> layout issue (WordPress/gutenberg#75599) - Notes: Fix block toolbar click action (WordPress/gutenberg#75614) - Commands: Add category property to command registration (WordPress/gutenberg#75612) - fix tab color-reset-all-filter (WordPress/gutenberg#75606) - Fix selection restoration after entity navigation (WordPress/gutenberg#75371) - Tabs: Sanitize tab_id (WordPress/gutenberg#75615) - Inherit text color for tabs-menu-item blocks (WordPress/gutenberg#75621) - Auto-switch viewport based on Overlay Visibility setting when entering overlay editor (WordPress/gutenberg#75386) - Fix: Show and hook up submenu visibility for Page Lists within Navigation Blocks (WordPress/gutenberg#75531) - Remove useEffect guard rail to enforce minimum width. (WordPress/gutenberg#75624) - Navigation: select list view tab on contentOnly. Alternative with explicit solution (WordPress/gutenberg#75578) - Navigation overlay: added basic e2e tests (WordPress/gutenberg#75581) - Revert Tabs block to experimental block (WordPress/gutenberg#75572) - List Block: Prevent content loss when merging into a fresh empty list item (WordPress/gutenberg#74382) - Fix Overlay core patterns not showing on design tab (WordPress/gutenberg#75618) - Rename Verse block to Poetry (WordPress/gutenberg#74121) - Fix Navigation block button showing "View custom" instead of "View link" for external URLs (WordPress/gutenberg#75571) - Removed Unused Global Documentation (WordPress/gutenberg#75631) - Real-time collaboration: Add sync connection status handling (WordPress/gutenberg#75066) - Add e2e test for selection restoration after pattern entity navigation (WordPress/gutenberg#75575) - Remove the Icon Block and Icon SVG API from experiments (WordPress/gutenberg#75576) - Block editor cross origin isolation: attempt to gracefully deal with race conditions (WordPress/gutenberg#75600) - Update diff package (WordPress/gutenberg#75644) - Upload Media: rebase of 75547 (WordPress/gutenberg#75646) - Block Editor: Allow disabling content-only editing for unsynced patterns (WordPress/gutenberg#75457) - Real-Time Collaboration: Add e2e tests for RTC (WordPress/gutenberg#75598) - Update the y-protocols versin and remove the unncessary types (WordPress/gutenberg#75657) - Pattern Editing: Add "Edit section" button to unsynced pattern toolbar (WordPress/gutenberg#75602) - PHP-Only Block Registration: Remove client-side schema validation (WordPress/gutenberg#75623) - Navigation: Add 'expectedDeprecated' annotations (WordPress/gutenberg#75659) - Site Editor: make QuickEdit stable + change template to select (WordPress/gutenberg#75565) - Icon Block: Move default width rule to theme.json instead of block.json (WordPress/gutenberg#75653) - Add e2e test for loading settings in site editor preload spec (WordPress/gutenberg#75661) - Update Ariakit packages (WordPress/gutenberg#75620) - Upgrade Playwright to v1.58 (WordPress/gutenberg#75632) - GitHub actions: Exclude lib/theme.json from backport changelog check (WordPress/gutenberg#75666) - theme.json: Enable width support for icon block by default (WordPress/gutenberg#75665) - Icons: Trim list of public icons further (WordPress/gutenberg#75630) - Update Navigation block tests to use non-deprecated API (WordPress/gutenberg#75660) - Update navigation block tests to use gutenberg version of block_core_navigation_block_tree_has_block_type - works on old wp versions (WordPress/gutenberg#75673) - Update copy (WordPress/gutenberg#75663) - Commands: Display category labels and enforce category icons (WordPress/gutenberg#75669) - Heading Block: Fix preview display (WordPress/gutenberg#75675) - Iframe: memoize src URL globally keyed by resolvedAssets (WordPress/gutenberg#75619) - ContrastChecker: Fix check for button block colors (WordPress/gutenberg#71959) - Writing flow: skip non-empty blocks on arrow key nav (WordPress/gutenberg#75141) - Comments Link: fix transforms textAlign (WordPress/gutenberg#75676) - Add initialSearchState to avoid console warnings from LinkControl inputValue change (WordPress/gutenberg#75643) - Migrate `EditorSnackbar` and `EditorNotices` components to the `@wordpress/notices` package (WordPress/gutenberg#74384) - Add minimum cap check to sync endpoint (WordPress/gutenberg#75681) - Fix: Hide link controls in sidebar when submenus open on click (WordPress/gutenberg#75637) - Set snackbar position to center (WordPress/gutenberg#75294) - Gallery: Fix PHP warning in random order image reordering (WordPress/gutenberg#75678) - DateCalendar, DateRangeCalendar: use lighter gray for disabled dates (WordPress/gutenberg#75683) - Pass unsupported formats directly to the server (WordPress/gutenberg#74910) - RTC: Compact on request with encodeStateAsUpdate (WordPress/gutenberg#75682) - Icons: Generate manifest PHP file based on JSON file (WordPress/gutenberg#75684) - ui/IconButton: make icon always 24px regardless of `size` prop (WordPress/gutenberg#75677) - Gallery: Skip interactivity directives when no images have lightbox enabled (WordPress/gutenberg#75680) - DataForm: Fix focus loss and refactor Card layout (WordPress/gutenberg#75689) - Remove IS_GUTENBERG_PLUGIN checks for collaborative editing (WordPress/gutenberg#75699) git-svn-id: https://develop.svn.wordpress.org/trunk@61680 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress/wordpress-develop#10968. Props ellatrix, adamsilverstein, youknowriad. See #64595. --- I've included a log of the Gutenberg changes with the following command: git log --reverse --format="- %s" 59a08c5496008ca88f4b6b86f38838c3612d88c8..7a11a53377a95cba4d3786d71cadd4c2f0c5ac52 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy - Remove unnecessary block deprecation from experimental tabs (WordPress/gutenberg#75208) - Block Editor: The insertBlock(s) actions should receive the same arguments (WordPress/gutenberg#75197) - Storybook: Always load design tokens in Design System section (WordPress/gutenberg#74899) - Default all initial suggested results to 20 for navigation link ui (WordPress/gutenberg#75186) - Navigation overlay: remove experiment (WordPress/gutenberg#74968) - Move AwarenessState to @wordpress/core-data (WordPress/gutenberg#75216) - RichText: Avoid stale active formats when deleting the text (WordPress/gutenberg#75227) - Fix <CollaboratorsPresence> type imports (WordPress/gutenberg#75232) - Block Editor: Add l10n context to 'Manage allowed blocks' string (WordPress/gutenberg#75239) - Fixed: Custom colors are now reflected in the editor for heading blocks (WordPress/gutenberg#75234) - Real-time Collaboration: Fix revision restore bug (WordPress/gutenberg#75233) - Real-time collaboration: Update 'sync.providers' filter inline comments (WordPress/gutenberg#75248) - Real-time collaboration: Make the collaborators presense button translatable (WordPress/gutenberg#75252) - Fix: Navigation Overlay Close Block: Add missing @SInCE tag WordPress/gutenberg#75247 (WordPress/gutenberg#75250) - Cover: Add new "fullheight" icon, and use for Cover (WordPress/gutenberg#75240) - Real-time collaboration: Remove @wordpress/sync from bundled packages and add private APIs (WordPress/gutenberg#74671) - Navigation Link: Clarify Link To invalid and draft state messages (WordPress/gutenberg#74054) - Docs: Simplifying Gutenberg versions table (WordPress/gutenberg#75209) - UI: Remove Box component abstraction (WordPress/gutenberg#74986) - Docs: Remove private GitHub team links in repository management (WordPress/gutenberg#75255) - UI: Add `Textarea` primitive (WordPress/gutenberg#74707) - Components: Add usage guidance for agents and Storybook (WordPress/gutenberg#74815) - Theme: Update elevation tokens to use abbreviated size names (WordPress/gutenberg#75103) - Navigation link: fix resetting link from the tools panel (WordPress/gutenberg#75228) - List View Support: Only render list view on top level block with support (WordPress/gutenberg#75166) - Gallery: Add lightbox support (WordPress/gutenberg#62906) - Workflows: Ignore icons manifest for manual backports (WordPress/gutenberg#75245) - Add new `adaptiveSelect` DataForm control (WordPress/gutenberg#74937) - Site Editor Pages: QuickEdit as a modal (WordPress/gutenberg#75173) - Add block rename keyboard shortcut (WordPress/gutenberg#74454) - Playlist block: Remove border (WordPress/gutenberg#75202) - Widget Area: Disable renaming and visibility support (WordPress/gutenberg#75279) - @wordpress/theme: add missing CHANGELOG entries (WordPress/gutenberg#75281) - Storybook: Add Stories for LetterSpacingControl component (WordPress/gutenberg#73480) - Remove the client from the awareness state when they disconnect (WordPress/gutenberg#75253) - Fix awareness timeout documentation unit (WordPress/gutenberg#75284) - Add global setting to enable real-time collaboration (WordPress/gutenberg#75286) - Notes: Pressing Escape should cancel adding a note (WordPress/gutenberg#75288) - Real-time Collaboration: Change users to collaborators (WordPress/gutenberg#75237) - Add timestamp when publishing next versions (WordPress/gutenberg#75293) - Storybook: Preserve export order for stories (WordPress/gutenberg#75295) - ToggleControl: Prevent console warning for `__nextHasNoMarginBottom` (WordPress/gutenberg#75296) - Quick edit: Make footer sticky (WordPress/gutenberg#75297) - DataForm Regular layout: label always uppercase (WordPress/gutenberg#75292) - @wordpress/ui: add Dialog component (WordPress/gutenberg#75183) - Navigation Link: Go to page link and edit page for inspector sidebar (WordPress/gutenberg#75262) - SiteEditor Pages: prevent QuickEdit modal from being triggered in list layout via URL param (WordPress/gutenberg#75300) - Link Control: Fix validation timing (WordPress/gutenberg#75267) - Publishing packages: fix next timestamp (WordPress/gutenberg#75301) - Add storybook for ColorPaletteControl (WordPress/gutenberg#74425) - Post Comments Form: Migrate to text-align block support (WordPress/gutenberg#75322) - Post Comments Count: Migrate to text-align block support (WordPress/gutenberg#75321) - Optimize tabsList computation with useRef for comparison (WordPress/gutenberg#75219) - Accordion block: Add list view support (WordPress/gutenberg#75271) - Media Fields: Filter author field to only show users with authoring capabilities (WordPress/gutenberg#75328) - Fields: Fix `authorField` query (WordPress/gutenberg#75298) - Slot: fix ref forwarding (WordPress/gutenberg#75274) - wp-env: Add --config option for custom config files (WordPress/gutenberg#75087) - Update Emotion for React 19 compat (WordPress/gutenberg#75324) - Block Visibility: Show keyboard shortcut hint in context menu (WordPress/gutenberg#75334) - Updated Typo in template-activate file (WordPress/gutenberg#75333) - wp-env: fix status command (WordPress/gutenberg#75325) - Playlist block:Inherit more CSS (WordPress/gutenberg#75256) - DataViews: Add onReset prop for view persistence reset (WordPress/gutenberg#75093) - Notes: Add a keyboard shortcut for creating a new note (WordPress/gutenberg#75287) - Storybook: Fix missing props on certain components (WordPress/gutenberg#75316) - Pattern Editing: Allow click through to List View (WordPress/gutenberg#75246) - Block Bindings: Have block fields panel reflects bound attribute value (WordPress/gutenberg#72096) - Fix: ISO 8601 compliant year formatting in TimePicker (WordPress/gutenberg#75343) - Prevent fatal error when the inline CSS duotone variable is an array (WordPress/gutenberg#75283) - Bugfix: Set the removed users to empty for awareness (WordPress/gutenberg#75337) - Button: prevent outline flicker when focused and active at the same time (WordPress/gutenberg#75346) - Real-time collaboration: Always target autosave revision (WordPress/gutenberg#75105) - In-editor revisions: add visual diffing (WordPress/gutenberg#75049) - iAPI Router: Update cached styles for re-fetched pages (WordPress/gutenberg#75097) - Add tests for the awareness code in core-data (WordPress/gutenberg#75074) - Add tests for the awareness code in sync (WordPress/gutenberg#75077) - Lock save button during Client Side Media processing and uploading (WordPress/gutenberg#74951) - Real-time Collaboration: Fix broken unit tests for awareness (WordPress/gutenberg#75362) - Boot: Fix mobile admin bar covering single-page mode headers (WordPress/gutenberg#75339) - Design System: Add guidelines for save and submit UX (WordPress/gutenberg#74811) - Featured Image: fix select-default-value (WordPress/gutenberg#75358) - Breadcrumbs: Improve loading state rendering (WordPress/gutenberg#75383) - Block Editor: Remove formatting controls restriction private API (WordPress/gutenberg#75382) - Link Control: Validate on submit (WordPress/gutenberg#75310) - Rich Text: Remove min-width inline style causing flex layout issues (WordPress/gutenberg#75370) - Tabs: Tidy up UI for controls (WordPress/gutenberg#75309) - Core Block Reference: Fix object empty inner key processing (WordPress/gutenberg#75391) - Improve sync performance metrics (WordPress/gutenberg#75029) - DataForm: update panel trigger (WordPress/gutenberg#75290) - Block Editor: Fix Columns block horizontal spacing when setting vertical gap (WordPress/gutenberg#75355) - DataViews Filters: Fix styling of long values in filter dropdown (WordPress/gutenberg#75369) - Try swapping tabs (WordPress/gutenberg#75194) - RichText: move useFormatTypes to rich-text package (WordPress/gutenberg#75387) - Make all navigation overlay close buttons work (WordPress/gutenberg#75384) - Block Editor: Improve Background panel UI in Global Styles (WordPress/gutenberg#75230) - Tabs: Update Tabs block icons (WordPress/gutenberg#75376) - Accordion: Move Accordion icons to Icon library (WordPress/gutenberg#75380) - Fix: Changing URL in link after changing text outside the popover resets it (WordPress/gutenberg#75342) - Update icon manifest acronyms. (WordPress/gutenberg#75418) - Code Modernization: Use null coalescing operator in additional `isset() ternaries. (WordPress/gutenberg#75419) - Pattern Editing: Move List View selectors to private-selectors (WordPress/gutenberg#75414) - DataViews: Use public ColorPicker instead of internal Picker export (WordPress/gutenberg#75394) - Abilities: Allow nested namespace ability names (2-4 segments) (WordPress/gutenberg#75393) - Fix: Remove backport changelog committed by mistake (WordPress/gutenberg#75441) - Block Visibility: Simplify toolbar for hidden blocks (WordPress/gutenberg#75335) - Block Visibility: Centralize modal state in block-editor store (WordPress/gutenberg#75367) - Allow grid to use style variation blockGap values for columns calculation (WordPress/gutenberg#75360) - Langauge Format: Add missing attribute definiton (WordPress/gutenberg#75422) - Block transform command: pass the block icon src rather than a BlockIcon component (WordPress/gutenberg#75365) - Note: Remove block highlight when deleting parent note (WordPress/gutenberg#75453) - Core Data: Improve blocks cache in useEntityBlockEditor (WordPress/gutenberg#75400) - MediaEdit: Support ordered values and reordering of items (WordPress/gutenberg#75207) - Writing flow: fix select all with full formatting (WordPress/gutenberg#64934) - Filter navigation category patterns to only show in navigation-overlay template part context (WordPress/gutenberg#75276) - Update Testing Library for React 19 compat (WordPress/gutenberg#75340) - Writing Flow: Fix block selection from partially selected RichText (WordPress/gutenberg#75449) - Notes: Fix sidebar display logic for small screens (WordPress/gutenberg#75454) - Post editor: iframe: check inserted rather than registered block versions (WordPress/gutenberg#75187) - Block Visibility: Disable visibility toggle for children of sections (WordPress/gutenberg#75447) - Notes: Update shortcut category (WordPress/gutenberg#75461) - Add dedicated navigation-overlay icon (WordPress/gutenberg#75249) (WordPress/gutenberg#75426) - Docs: Rename Interactivity API's 'API Reference' to 'Directives and Store' (WordPress/gutenberg#74974) - DataForm: Fix color picker styles (WordPress/gutenberg#75427) - Post Excerpt Block: Remove REST API filter for excerpt length in post excerpt block (WordPress/gutenberg#75299) - Move experimental PR out of backport log (WordPress/gutenberg#75465) - Add paste logging to writing flow (WordPress/gutenberg#73885) - Real-time collaboration: Sync post content and undefined `blocks` value (WordPress/gutenberg#75437) - Gutenberg plugin: always enforce the iframe in the post editor (WordPress/gutenberg#75475) - New Block: Icon Block (WordPress/gutenberg#71227) - Tabs: Improve tab keyboard nav (WordPress/gutenberg#75471) - Pre-populate Navigation Page Creator with Search Text (WordPress/gutenberg#75154) - Block Library: Hide navigation-overlay template parts from inserter (WordPress/gutenberg#75478) - Tabs: Add text and background color support (WordPress/gutenberg#75482) - Preserve existing URLInput defaults (WordPress/gutenberg#75392) - UI: Remove unnecessary jest.setTimeout from Select test (WordPress/gutenberg#75444) - Fix missed dimension token migration in UI package (WordPress/gutenberg#75446) - Render default density selector last in design tokens CSS (WordPress/gutenberg#75474) - Navigation: Improved help text in create a page flow (WordPress/gutenberg#75349) - Fix gap token migration guide in changelog (WordPress/gutenberg#75492) - Block Visibility: Disable Apply button on non-dirty state (WordPress/gutenberg#75494) - Real-time Collaboration: Use Y.text for title, content and excerpt (WordPress/gutenberg#75448) - DataForm: Style SummaryButton in panel layout with `is-disabled` classname (WordPress/gutenberg#75470) - Gallery: Add list view block support (WordPress/gutenberg#75407) - Types: consistently use the React namespace (WordPress/gutenberg#75499) - Enhance block appender labels to reflect default block type (WordPress/gutenberg#71502) - Import Yjs correctly (WordPress/gutenberg#75500) - Add testsEnvironment option and split Gutenberg wp-env configs (WordPress/gutenberg#75341) - Add `clearEntityRecordEdits` action to core-data (WordPress/gutenberg#75397) - Tabs: Stabilize Tabs blocks (WordPress/gutenberg#75424) - Simplify Tabs Menu Item editing (WordPress/gutenberg#75416) - Fix LinkControl URL Normalization (WordPress/gutenberg#75488) - Navigation Submenu: Restore openSubmenusOnClick to usesContext for backward compatibility. (WordPress/gutenberg#75435) - Tabs: Add `@since 7.0.0` annotations (WordPress/gutenberg#75521) - Story types: fix StoryFns used as React components (WordPress/gutenberg#75472) - Tabs: fix incorrect fixtures (WordPress/gutenberg#75523) - AGENTS.md: Add CLAUDE.md symlinks, architecture decisions, and common pitfalls (WordPress/gutenberg#75507) - Use contextual snackbar text when activating a theme from preview (WordPress/gutenberg#75385) - Pick user fields instead of spreading the entire object (WordPress/gutenberg#75528) - Real-time collaboration: Move PHP code to compat / backports directory (WordPress/gutenberg#75366) - Icons: Fix incorrect attributes for SVG (WordPress/gutenberg#75273) - Icons: Make full height icon label title case (WordPress/gutenberg#75524) - Respect deprecated openSubmenusOnClick value on frontend rendering (WordPress/gutenberg#75439) - useRef: always supply initial value (WordPress/gutenberg#75513) - Code Modernization: Replace isset() checks with null coalescing operator (WordPress/gutenberg#75425) - Prefix usages of JSX namespaces with React.JSX (WordPress/gutenberg#75508) - Cleanup: Remove unnecessary array check in `WP_Theme_JSON_Gutenberg` (WordPress/gutenberg#75515) - Real-time collaboration: Add collaborators cursor awareness (WordPress/gutenberg#75398) - Post Comments Link: Migrate to Text-Align Block Support (WordPress/gutenberg#75332) - Post time to read: Migrate to Text-Align Block Support (WordPress/gutenberg#75541) - ExternalLink: Prevent Twemoji from replacing arrow (WordPress/gutenberg#75538) - Duotone: add sgomes as owner (WordPress/gutenberg#75519) - Use null coalescing operator for common isset patterns (WordPress/gutenberg#75487) - Term Description: Migrate to Text-Align Block Support (WordPress/gutenberg#75542) - Create sub-sized images (WordPress/gutenberg#74566) - Add EXIF metadata tests for Client Side Media (WordPress/gutenberg#74909) - Add AVIF, WebP and MozJPEG output encoding support (WordPress/gutenberg#75081) - Post Terms: Migrate to Text-Align Block Support (WordPress/gutenberg#75545) - Tabs: Make Example preview translatable (WordPress/gutenberg#75555) - List View tab: Ensure it's populated when first selecting a container block (WordPress/gutenberg#75558) - Fix auto draft bug for Y.text titles (WordPress/gutenberg#75560) - Border Support: Fix editor split border style fallback (WordPress/gutenberg#75546) - Block Editor: Avoid unnecessary state churn in controlled inner blocks reducers (WordPress/gutenberg#75458) - Block Lock: Disable Apply button on non-dirty state (WordPress/gutenberg#75495) - Post Terms: Avoid unbound queries when the post context isn't available (WordPress/gutenberg#75536) - wp-env Playground: improve mapping and core source handling (WordPress/gutenberg#75527) - DataForm: add edit variant (WordPress/gutenberg#75462) - Tabs: Improve Tab Panel accessibility (WordPress/gutenberg#75484) - Tabs: Remove name editing UI (WordPress/gutenberg#75554) - useBlockSync: stop reconstructing controlled inner blocks (WordPress/gutenberg#75562) - Notes: Fix new note creation from the List View (WordPress/gutenberg#75566) - Navigation: Update overlay template part naming to "Navigation Overlay" (WordPress/gutenberg#75564) - Update usage of RefObject types (React 19 compat) (WordPress/gutenberg#75567) - useMergeRefs: migrate to TypeScript (WordPress/gutenberg#75569) - Improve link preview badges (WordPress/gutenberg#75318) - Add getDimensionsClassesAndStyles function and related tests (WordPress/gutenberg#74524) - Informational Parity between Inspector Link Preview and on Canvas Link Preview (WordPress/gutenberg#75399) - Icons Registry: Don't expose "internal" icons (WordPress/gutenberg#75526) - ui/Button: fix disabled styles and variable composition (WordPress/gutenberg#75568) - Tabs: Set explicit font-family on tab buttons (WordPress/gutenberg#75537) - Interactivity API: Export `watch` from `@preact/signals`'s `effect` (WordPress/gutenberg#75563) - iAPI router: Move internal properties to a private store (WordPress/gutenberg#70882) - Post Excerpt: Add text columns support (WordPress/gutenberg#75587) - Update gutenberg to match core after WordPress/gutenberg#75360 sync (WordPress/gutenberg#75594) - Block Visibility: Show viewport icons and tooltip in list view for hidden blocks (WordPress/gutenberg#75404) - [Real-time collaboration] Refine collaborator overlay with Avatar component integration (WordPress/gutenberg#75595) - Media Utils: Auto-select uploaded files in media modal experiment (WordPress/gutenberg#75597) - Try enabling paragraphs to be added to contentOnly patterns (WordPress/gutenberg#73222) - Implement WebAssembly support detection and fallbacks (WordPress/gutenberg#74827) - Icon block: Skip serialization and increase default size (WordPress/gutenberg#75553) - In-editor Revisions: Update success notice message (WordPress/gutenberg#75411) - Stabilize PHP-Only Block Registration (WordPress/gutenberg#75543) - Add comments around expandRevision functionality (WordPress/gutenberg#75573) - Tab Block: Ensure label formatting works correctly (WordPress/gutenberg#75548) - Tabs: Fix saved HTML (WordPress/gutenberg#75580) - [Real-time collaboration] Fix <CollaboratorsPresence> layout issue (WordPress/gutenberg#75599) - Notes: Fix block toolbar click action (WordPress/gutenberg#75614) - Commands: Add category property to command registration (WordPress/gutenberg#75612) - fix tab color-reset-all-filter (WordPress/gutenberg#75606) - Fix selection restoration after entity navigation (WordPress/gutenberg#75371) - Tabs: Sanitize tab_id (WordPress/gutenberg#75615) - Inherit text color for tabs-menu-item blocks (WordPress/gutenberg#75621) - Auto-switch viewport based on Overlay Visibility setting when entering overlay editor (WordPress/gutenberg#75386) - Fix: Show and hook up submenu visibility for Page Lists within Navigation Blocks (WordPress/gutenberg#75531) - Remove useEffect guard rail to enforce minimum width. (WordPress/gutenberg#75624) - Navigation: select list view tab on contentOnly. Alternative with explicit solution (WordPress/gutenberg#75578) - Navigation overlay: added basic e2e tests (WordPress/gutenberg#75581) - Revert Tabs block to experimental block (WordPress/gutenberg#75572) - List Block: Prevent content loss when merging into a fresh empty list item (WordPress/gutenberg#74382) - Fix Overlay core patterns not showing on design tab (WordPress/gutenberg#75618) - Rename Verse block to Poetry (WordPress/gutenberg#74121) - Fix Navigation block button showing "View custom" instead of "View link" for external URLs (WordPress/gutenberg#75571) - Removed Unused Global Documentation (WordPress/gutenberg#75631) - Real-time collaboration: Add sync connection status handling (WordPress/gutenberg#75066) - Add e2e test for selection restoration after pattern entity navigation (WordPress/gutenberg#75575) - Remove the Icon Block and Icon SVG API from experiments (WordPress/gutenberg#75576) - Block editor cross origin isolation: attempt to gracefully deal with race conditions (WordPress/gutenberg#75600) - Update diff package (WordPress/gutenberg#75644) - Upload Media: rebase of 75547 (WordPress/gutenberg#75646) - Block Editor: Allow disabling content-only editing for unsynced patterns (WordPress/gutenberg#75457) - Real-Time Collaboration: Add e2e tests for RTC (WordPress/gutenberg#75598) - Update the y-protocols versin and remove the unncessary types (WordPress/gutenberg#75657) - Pattern Editing: Add "Edit section" button to unsynced pattern toolbar (WordPress/gutenberg#75602) - PHP-Only Block Registration: Remove client-side schema validation (WordPress/gutenberg#75623) - Navigation: Add 'expectedDeprecated' annotations (WordPress/gutenberg#75659) - Site Editor: make QuickEdit stable + change template to select (WordPress/gutenberg#75565) - Icon Block: Move default width rule to theme.json instead of block.json (WordPress/gutenberg#75653) - Add e2e test for loading settings in site editor preload spec (WordPress/gutenberg#75661) - Update Ariakit packages (WordPress/gutenberg#75620) - Upgrade Playwright to v1.58 (WordPress/gutenberg#75632) - GitHub actions: Exclude lib/theme.json from backport changelog check (WordPress/gutenberg#75666) - theme.json: Enable width support for icon block by default (WordPress/gutenberg#75665) - Icons: Trim list of public icons further (WordPress/gutenberg#75630) - Update Navigation block tests to use non-deprecated API (WordPress/gutenberg#75660) - Update navigation block tests to use gutenberg version of block_core_navigation_block_tree_has_block_type - works on old wp versions (WordPress/gutenberg#75673) - Update copy (WordPress/gutenberg#75663) - Commands: Display category labels and enforce category icons (WordPress/gutenberg#75669) - Heading Block: Fix preview display (WordPress/gutenberg#75675) - Iframe: memoize src URL globally keyed by resolvedAssets (WordPress/gutenberg#75619) - ContrastChecker: Fix check for button block colors (WordPress/gutenberg#71959) - Writing flow: skip non-empty blocks on arrow key nav (WordPress/gutenberg#75141) - Comments Link: fix transforms textAlign (WordPress/gutenberg#75676) - Add initialSearchState to avoid console warnings from LinkControl inputValue change (WordPress/gutenberg#75643) - Migrate `EditorSnackbar` and `EditorNotices` components to the `@wordpress/notices` package (WordPress/gutenberg#74384) - Add minimum cap check to sync endpoint (WordPress/gutenberg#75681) - Fix: Hide link controls in sidebar when submenus open on click (WordPress/gutenberg#75637) - Set snackbar position to center (WordPress/gutenberg#75294) - Gallery: Fix PHP warning in random order image reordering (WordPress/gutenberg#75678) - DateCalendar, DateRangeCalendar: use lighter gray for disabled dates (WordPress/gutenberg#75683) - Pass unsupported formats directly to the server (WordPress/gutenberg#74910) - RTC: Compact on request with encodeStateAsUpdate (WordPress/gutenberg#75682) - Icons: Generate manifest PHP file based on JSON file (WordPress/gutenberg#75684) - ui/IconButton: make icon always 24px regardless of `size` prop (WordPress/gutenberg#75677) - Gallery: Skip interactivity directives when no images have lightbox enabled (WordPress/gutenberg#75680) - DataForm: Fix focus loss and refactor Card layout (WordPress/gutenberg#75689) - Remove IS_GUTENBERG_PLUGIN checks for collaborative editing (WordPress/gutenberg#75699) Built from https://develop.svn.wordpress.org/trunk@61680 git-svn-id: http://core.svn.wordpress.org/trunk@60988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
| $overlay_callback = function () { | ||
| block_core_image_print_lightbox_overlay(); | ||
| }; | ||
| add_action( 'wp_footer', $overlay_callback ); |
There was a problem hiding this comment.
what is the purpose in turning this into a closure?
There was a problem hiding this comment.
It looks like this is a vestige of an earlier state in which a variable needed to be supplied via the closure. This was removed in 7b4faa9. So indeed this can be simplified to just:
| add_action( 'wp_footer', $overlay_callback ); | |
| add_action( 'wp_footer', 'block_core_image_print_lightbox_overlay' ); |












Originally written by @madhusudhand
Details
What?
This introduces lightbox functionality to
Galleryblock.How?
Following is the behaviour in various scenarios.
Case 1: "Expand on click" is enabled for the image block globally.
All images inside (unless overridden at block level), will invoke the lightbox on click and next and previous navigation is possible.
Case 2: One of the image (lets say 2nd image) is set to "Link to image file"
Lightbox will be invoked on click of 1st image and on click of next will move to 3rd image.
Case 3: "Expand on click" is not enabled globally, but few images are set with this option in gallery.
This is similar to case 2, lightbox opens with only those images.
What's in future PRs?
Screenshots (Draft)
Testing instructions
Related issues
First iteration of #56310
Latest description written by @t-hamano
What?
This PR enables navigation between images with lightbox enabled.
Why?
#56310
How?
but can be disabled in the block sidebar. If the feature is disabled, the image lightboxes themselves will work as before, but navigation between images will not be enabled:Update: Changed to always be enabled.aria-label, inject an element witharia-liveandaria-atomicattributes and vary the text inside. We could also usespeak, but the@wordpress/a11yscript module is available from WP 6.7. The Gutenberg plugin has to support WP 6.6 for now, so I didn't go with the speak approach.Testing Instructions
Disable "Lightbox navigation" in the Gallery block sidebar. A lightbox will open when you click on an image, but the back and next buttons will not be displayed.Testing Instructions for Keyboard
Tooltip text appears when the back and next buttons are hovered over or focused.Update: Based on this feedback, we removed the tooltip and instead added the aria-label attribute to the button.Enlarged image X of Y: {IMAGE_ALT_TEXT} dialogbutton unavailable Previous,button NextEnlarged image X of Y: {IMAGE_ALT_TEXT}Screenshots or screencast
6999948663987cac5545ba0e9eaa1a88.mp4