Add: className prop support to server side render.#13568
Merged
jorgefilipecosta merged 2 commits intomasterfrom Jan 31, 2019
Merged
Add: className prop support to server side render.#13568jorgefilipecosta merged 2 commits intomasterfrom
jorgefilipecosta merged 2 commits intomasterfrom
Conversation
jorgefilipecosta
added
[Type] Enhancement
gziolo
reviewed
Jan 30, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I haven't tested but code-wise it looks very good. Can you also update docs to mention className in the list of supported props?
jorgefilipecosta
force-pushed
the
add/class-prop-to-server-side-render
branch
from
c362d0b to
a044b48
Compare
jorgefilipecosta
force-pushed
the
add/class-prop-to-server-side-render
branch
from
a044b48 to
db5d777
Compare
Member
Author
|
Hi @gziolo,
Docs were added. |
gziolo
approved these changes
Jan 31, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I added a few tiny tweaks to the docs. Code wise everything looks great and tests well.
Member
Author
|
Thank you for the review and tweaks @gziolo! |
daniloercoli
added a commit
that referenced
this pull request
Feb 1, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: Try alternate list item jump fix. (#12941) Mobile bottom sheet component (#13612) Remove unintentional right-margin on last odd-item. (#12199) Introduce left and right float alignment options to latest posts block (#8814) Fix Google Docs table paste (#13543) Increase bottom padding on gallery image caption (#13623) Fix the editor save keyboard shortcut not working in code editor view (#13159) Plugin: Deprecate gutenberg_add_admin_body_class (#13572) Rnmobile/upload media failed state (#13615) Make clickOnMoreMenuItem not dependent on aria labels (#13166) Add: className prop support to server side render. (#13568) Fix: Categories Block: hierarchical Dropdown (#13567) Docs: Add clarification about git workflow (#13534) Plugin: Remove `user_can_richedit` filtering (#13608) eslint-plugin: Add rule `no-unused-vars-before-return` (#12828) Image settings button (#13597) Fixed wording for the color picker saturation (#13479) # Conflicts: # packages/block-library/src/image/edit.native.js
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Required by: #13511
In #13511 a need appeared where it was necessary to add some styles to the wrapper container of a ServerSideRender component.
In order to do that the easy way is to add className support for ServerSideRender.
How has this been tested?
I replaced the ServerSideRender usage on
packages/block-library/src/archives/edit.js with<ServerSideRender className="my-random-class" block="core/archives" attributes={ attributes } />I added an archives block I inspected the dom and I checked the class "my-random-class" was applied.