Skip to content

fix: add withTimezone to all wxyc_schema timestamp columns #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebromberg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add withTimezone to all wxyc_schema timestamp columns #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c887ca
fix: add withTimezone to all wxyc_schema timestamp columns
Feb 21, 2026
f715f08
fix: resolve lint errors
Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions shared/database/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export const shift_covers = wxyc_schema.table('shift_covers', {
schedule_id: serial('schedule_id')
.references(() => schedule.id)
.notNull(),
shift_timestamp: timestamp('shift_timestamp').notNull(), //Timestamp to expire cover requests
shift_timestamp: timestamp('shift_timestamp', { withTimezone: true }).notNull(), //Timestamp to expire cover requests
cover_dj_id: varchar('cover_dj_id', { length: 255 }).references(() => user.id),
covered: boolean('covered').default(false),
});
Expand All @@ -207,7 +207,7 @@ export const artists = wxyc_schema.table(
code_letters: varchar('code_letters', { length: 2 }).notNull(),
code_artist_number: smallint('code_artist_number').notNull(),
add_date: date('add_date').defaultNow().notNull(),
last_modified: timestamp('last_modified').defaultNow().notNull(),
last_modified: timestamp('last_modified', { withTimezone: true }).defaultNow().notNull(),
},
(table) => {
return {
Expand Down Expand Up @@ -247,8 +247,8 @@ export const library = wxyc_schema.table(
code_number: smallint('code_number').notNull(),
disc_quantity: smallint('disc_quantity').default(1).notNull(),
plays: integer('plays').default(0).notNull(),
add_date: timestamp('add_date').defaultNow().notNull(),
last_modified: timestamp('last_modified').defaultNow().notNull(),
add_date: timestamp('add_date', { withTimezone: true }).defaultNow().notNull(),
last_modified: timestamp('last_modified', { withTimezone: true }).defaultNow().notNull(),
},
(table) => {
return {
Expand Down Expand Up @@ -307,7 +307,7 @@ export const flowsheet = wxyc_schema.table('flowsheet', {
play_order: serial('play_order').notNull(),
request_flag: boolean('request_flag').default(false).notNull(),
message: varchar('message', { length: 250 }),
add_time: timestamp('add_time').defaultNow().notNull(),
add_time: timestamp('add_time', { withTimezone: true }).defaultNow().notNull(),
});

export type NewGenre = InferInsertModel<typeof genres>;
Expand All @@ -318,7 +318,7 @@ export const genres = wxyc_schema.table('genres', {
description: text('description'),
plays: integer('plays').default(0).notNull(),
add_date: date('add_date').defaultNow().notNull(),
last_modified: timestamp('last_modified').defaultNow().notNull(),
last_modified: timestamp('last_modified', { withTimezone: true }).defaultNow().notNull(),
});

export type NewReview = InferInsertModel<typeof reviews>;
Expand All @@ -331,7 +331,7 @@ export const reviews = wxyc_schema.table('reviews', {
.unique(),
review: text('review'),
add_date: date('add_date').defaultNow().notNull(),
last_modified: timestamp('last_modified').defaultNow().notNull(),
last_modified: timestamp('last_modified', { withTimezone: true }).defaultNow().notNull(),
author: varchar('author', { length: 32 }),
});

Expand Down Expand Up @@ -383,8 +383,8 @@ export const shows = wxyc_schema.table('shows', {
specialty_id: integer('specialty_id') //Null for regular shows
.references(() => specialty_shows.id),
show_name: varchar('show_name', { length: 128 }), //Null if not provided or specialty show
start_time: timestamp('start_time').defaultNow().notNull(),
end_time: timestamp('end_time'),
start_time: timestamp('start_time', { withTimezone: true }).defaultNow().notNull(),
end_time: timestamp('end_time', { withTimezone: true }),
});

export type NewShowDJ = InferInsertModel<typeof show_djs>;
Expand All @@ -407,7 +407,7 @@ export const specialty_shows = wxyc_schema.table('specialty_shows', {
specialty_name: varchar('specialty_name', { length: 64 }).notNull(),
description: text('description'),
add_date: date('add_date').defaultNow().notNull(),
last_modified: timestamp('last_modified').defaultNow().notNull(),
last_modified: timestamp('last_modified', { withTimezone: true }).defaultNow().notNull(),
});

export type LibraryArtistViewEntry = {
Expand Down Expand Up @@ -491,8 +491,8 @@ export const album_metadata = wxyc_schema.table(

// LRU cache management
is_rotation: boolean('is_rotation').default(false).notNull(),
last_accessed: timestamp('last_accessed').defaultNow().notNull(),
created_at: timestamp('created_at').defaultNow().notNull(),
last_accessed: timestamp('last_accessed', { withTimezone: true }).defaultNow().notNull(),
created_at: timestamp('created_at', { withTimezone: true }).defaultNow().notNull(),
},
(table) => {
return {
Expand Down Expand Up @@ -520,8 +520,8 @@ export const artist_metadata = wxyc_schema.table(
wikipedia_url: varchar('wikipedia_url', { length: 512 }),

// LRU cache management
last_accessed: timestamp('last_accessed').defaultNow().notNull(),
created_at: timestamp('created_at').defaultNow().notNull(),
last_accessed: timestamp('last_accessed', { withTimezone: true }).defaultNow().notNull(),
created_at: timestamp('created_at', { withTimezone: true }).defaultNow().notNull(),
},
(table) => {
return {
Expand Down
29 changes: 29 additions & 0 deletions tests/unit/database/schema.timestamps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import * as fs from 'fs';
import * as path from 'path';

describe('schema timestamp consistency', () => {
const schemaPath = path.resolve(__dirname, '../../../shared/database/src/schema.ts');
const schemaSource = fs.readFileSync(schemaPath, 'utf-8');

it('every timestamp() call should include { withTimezone: true }', () => {
// Match all timestamp( calls — captures the full invocation up to the closing paren
// of the column-type function (not chained methods).
// Pattern: timestamp('col_name') or timestamp('col_name', { ... })
const timestampCallRegex = /timestamp\(\s*'[^']+'\s*(?:,\s*\{[^}]*\})?\s*\)/g;
const matches = schemaSource.match(timestampCallRegex);

expect(matches).not.toBeNull();
if (!matches) return;

expect(matches.length).toBeGreaterThan(0);

const missing: string[] = [];
for (const match of matches) {
if (!match.includes('withTimezone: true')) {
missing.push(match);
}
}

expect(missing).toEqual([]);
});
});
Loading