fix: add withTimezone to all wxyc_schema timestamp columns#196
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: add withTimezone to all wxyc_schema timestamp columns#196jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
Timestamps without timezone are ambiguous during DST transitions. Auth tables already used withTimezone; now wxyc_schema tables match. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/39-timestamp-timezone
branch
from
55a3c3f to
6c887ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timestamp()columns inwxyc_schematables were missing{ withTimezone: true }, making them ambiguous during DST transitions. Auth tables (public schema) already usedwithTimezone. This aligns the two.tests/unit/database/schema.timestamps.test.ts) that reads the schema source and asserts everytimestamp()call includeswithTimezone: true, preventing future regressions.Affected tables
shift_covers,artists,library,flowsheet,genres,reviews,shows,specialty_shows,album_metadata,artist_metadataTest plan
Closes #39
Made with Cursor