Skip to content

fix: enable trust proxy for correct client IP resolution #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebromberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable trust proxy for correct client IP resolution #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/backend/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import { requirePermissions } from '@wxyc/authentication';
const port = process.env.PORT || 8080;
const app = express();

app.set('trust proxy', true);

//Interpret parse json into js objects
app.use(express.json());

Expand Down
10 changes: 10 additions & 0 deletions tests/unit/config/trust-proxy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { readFileSync } from 'fs';
import { resolve } from 'path';

describe('Express trust proxy configuration', () => {
const appSource = readFileSync(resolve(__dirname, '../../../apps/backend/app.ts'), 'utf-8');

it('should enable trust proxy so req.ip reflects the real client IP behind a reverse proxy', () => {
expect(appSource).toMatch(/app\.set\(\s*['"]trust proxy['"]/);
});
});
Loading