fix: enable trust proxy for correct client IP resolution#185
Open
jakebromberg wants to merge 1 commit intomainfrom
Open
fix: enable trust proxy for correct client IP resolution#185jakebromberg wants to merge 1 commit intomainfrom
jakebromberg wants to merge 1 commit intomainfrom
Conversation
Without trust proxy, req.ip returns the load balancer IP, making IP-based rate limiting ineffective behind a reverse proxy. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/24-trust-proxy
branch
from
89e7b13 to
5e6e885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.set('trust proxy', true)toapps/backend/app.tsso thatreq.ipreturns the real client IP instead of the load balancer's IP when running behind a reverse proxy.tests/unit/config/trust-proxy.test.ts) that reads the app source and asserts the trust proxy setting is present.Closes #24
Test plan
req.ipreturns the correct client IP in staging behind the ALB/reverse proxyMade with Cursor