This repository was archived by the owner on Jan 28, 2026. It is now read-only.
[spec] Support transactional batchUpdate()#231
Merged
Conversation
The spec changes for #228 Specifically: - Add a "batch update entries in the database" algorithm that provides transactional support. Switch to call this algorithm for batchUpdate(). - `batchUpdate()` now explicitly throws an exception when any inner method specifies the `withLock` option, preventing unintended behavior. - For headers, if `with_lock` is specified for any inner method, the whole batch will be ignored as well. This integrates seamlessly with the existing "handle a Shared-Storage-Write response" algorithm, which invokes `batchUpdate()` in the end and will trigger the failure as intended.
Collaborator
Author
|
@pythagoraskitty PTAL. Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Mar 21, 2025
SHA: b8a37bd Reason: push, by xyaoinum Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2025
…hod locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 31, 2025
…hod locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2025
…hod locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 31, 2025
…hod locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 4, 2025
…te() cannot contain inner method locks, a=testonly Automatic update from web-platform-tests [shared storage] Validate that batchUpdate() cannot contain inner method locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291} -- wpt-commits: 86858ee83ee8acec885b42923b656a61fde7f257 wpt-pr: 51720
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Apr 4, 2025
…te() cannot contain inner method locks, a=testonly Automatic update from web-platform-tests [shared storage] Validate that batchUpdate() cannot contain inner method locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291} -- wpt-commits: 86858ee83ee8acec885b42923b656a61fde7f257 wpt-pr: 51720
globau
pushed a commit
to globau/firefox-test
that referenced
this pull request
Apr 8, 2025
…te() cannot contain inner method locks, a=testonly Automatic update from web-platform-tests [shared storage] Validate that batchUpdate() cannot contain inner method locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291} -- wpt-commits: 86858ee83ee8acec885b42923b656a61fde7f257 wpt-pr: 51720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec changes for #228
Specifically:
batchUpdate()now explicitly throws an exception when any inner method specifies thewithLockoption, preventing unintended behavior.with_lockis specified for any inner method, the whole batch will be ignored as well. This integrates seamlessly with the existing "handle a Shared-Storage-Write response" algorithm, which invokesbatchUpdate()in the end and will trigger the failure as intended.Preview | Diff