[shared storage] Validate that batchUpdate() cannot contain inner method locks#51720
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 31, 2025
Merged
Conversation
…hod locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6393777
branch
from
0d16bde to
ebe01fa
Compare
wpt-pr-bot
approved these changes
Mar 31, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the transactional batchUpdate() proposal (spec PR:[1]),
inner method locks are no longer permitted. This CL implements
validation in both the caller code and mojom traits.
Note that while unrecognized IDL dictionary fields are generally
allowed, strict validation is enforced for this deprecated
'withLock' field to prevent potential misuse.
[1] WICG/shared-storage#231
Bug: 404568020
Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1440291}