Skip to content

Enchantment table incorrect upgrades level when "Upgrades Active = false" bugs fixes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FominArtmind wants to merge 3 commits into
base: releases/EpicLoot/v0.9.37-vapok
Choose a base branch
from
Open

Enchantment table incorrect upgrades level when "Upgrades Active = false" bugs fixes #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29ffc9b
Fixed bug with incorrect initial value of enchantment table upgrades …
Feb 19, 2024
2894def
Hotfix
Feb 19, 2024
a9ffad8
Trying to improve enchant table appearance when no upgrades are avail…
Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EpicLoot-UnityLib/EnchantingTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class EnchantingTable : MonoBehaviour, Hoverable, Interactable
public const string DisplayNameLocID = "mod_epicloot_assets_enchantingtable";
public const int FeatureUnavailableSentinel = -2;
public const int FeatureLockedSentinel = -1;
public const int FeatureLevelOne = 1;
public const int FeatureLevelOne = 0;

public GameObject EnchantingUIPrefab;

Expand Down
6 changes: 6 additions & 0 deletions EpicLoot-UnityLib/FeatureStatus3D.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ public void Refresh()
UnlockedObject.SetActive(featureIsUnlocked);

var currentLevel = SourceTable.GetFeatureLevel(Feature);
if(!EnchantingTable.UpgradesActive(Feature, out bool featureActive))
{
// To improve table appearance when no upgrades are available ever
currentLevel = 1;
}

for (var index = 0; index < LevelObjects.Length; index++)
{
var levelObject = LevelObjects[index];
Expand Down
5 changes: 5 additions & 0 deletions EpicLoot/CraftingV2/EnchantingTable_Patch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ public static void Postfix(Piece __instance)
if (table == null)
return;

if(!EpicLoot.EnchantingTableUpgradesActive.Value)
{
return;
}

foreach (EnchantingFeature feature in Enum.GetValues(typeof(EnchantingFeature)))
{
if (!table.IsFeatureAvailable(feature) || table.IsFeatureLocked(feature))
Expand Down