Skip to content

Conversation

@FominArtmind
Copy link

Motivation: when "Upgrades Active = false" config setting was set, it led to the following bugs and issues:

  • when enchantment level is destroyed, it drops all level 1 upgrades materials. Thus, a player can build and destroy Enchantment table multiple times gaining unlimited amount of surtling cores, coins, tokens etc
  • default value of upgrades 1 is inconsistent with the goal of the config setting itself, that is, the player still sees and gets upgrades bonuses for level 1 upgrades but not being able to improve them. More reasonable behavior is not having any information about upgrades at all and don't gain any effects from them (theoretically, default bonuses for level 1 upgrades can change in the future and this will change the experience of "Upgrades Active = false" users also which is illogical).

What actually done:

  • changed default "Upgrades Active = false" enchanment table upgrades level to 0
  • fixed the logic of calculation enchanment table drops on its destroying
  • made visual appearance of enchantment table in the game when "Upgrades Active = false" to mimic level 1 upgrades since level 0 enchantment table looks rather empty (maybe it was the main reason for previous level 1 upgrades set by default for "Upgrades Active = false" )

Backward compatibility: should not provide issues for the existent users

Arsenii Fomin added 3 commits February 19, 2024 10:52
…when "Upgrades Active = false" leading to duping of items on the table build/destroy cycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant