Skip to content

Luck formula change to work properly with any rarity distributions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FominArtmind wants to merge 1 commit into
base: releases/EpicLoot/v0.9.37-vapok
Choose a base branch
from
Open

Luck formula change to work properly with any rarity distributions #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 10 additions & 32 deletions EpicLoot/LootRoller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,16 @@ public static Dictionary<ItemRarity, float> GetRarityWeights(float[] rarity, flo
{ ItemRarity.Legendary, rarity.Length >= 4 ? rarity[3] : 0 }
};

return ModifyRarityByLuck(rarityWeights, luckFactor);
for (var r = ItemRarity.Legendary; r >= ItemRarity.Magic; r--)
{
if (rarityWeights[r] > 0)
{
rarityWeights[r] = rarityWeights[r] * (1 + luckFactor);
break;
}
}

return rarityWeights;
}

public static List<LootTable> GetLootTable(string objectName)
Expand Down Expand Up @@ -878,37 +887,6 @@ public static void DebugLuckFactor()
}
}

public static Dictionary<ItemRarity, float> ModifyRarityByLuck(IReadOnlyDictionary<ItemRarity, float> rarityWeights, float luckFactor = 0)
{
var results = new Dictionary<ItemRarity, float>();
for (var rarity = ItemRarity.Magic; rarity <= ItemRarity.Legendary; rarity++)
{
var skewFactor = GetSkewFactor(rarity);
results.Add(rarity, rarityWeights[rarity] * GetSkewedLuckFactor(luckFactor, skewFactor));
}

return results;
}

public static float GetSkewFactor(ItemRarity rarity)
{
switch (rarity)
{
case ItemRarity.Magic: return -0.2f;
case ItemRarity.Rare: return 0.0f;
case ItemRarity.Epic: return 0.2f;
case ItemRarity.Legendary: return 1;
case ItemRarity.Mythic: return 1.1f;
default:
throw new ArgumentOutOfRangeException(nameof(rarity), rarity, null);
}
}

public static float GetSkewedLuckFactor(float luckFactor, float skewFactor)
{
return Mathf.Max(0, 1 + luckFactor * skewFactor);
}

public static void PrintLuckTest(string lootTableName, float luckFactor)
{
var lootTable = GetLootTable(lootTableName)[0];
Expand Down