Full system flags compatability #3594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarrryNight
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
| logging.debug("Binary support flags: {}".format(supported_flags)) | ||
| else: | ||
| logging.warning( | ||
| "Could not discovery flags for path: '{}'. Continuing...".format( |
Contributor
There was a problem hiding this comment.
Typo here. Should be "discover".
| try: | ||
| result = subprocess.run( | ||
| [path_to_binary, "--help"], capture_output=True, text=True, timeout=3 | ||
| ) |
Contributor
There was a problem hiding this comment.
Would some binaries print --help to stderr (diagnostic output)? If so, we could merge stdout and stderr?
output = (result.stdout or "") + (result.stderr or "")
flags = re.findall(r"--(\w+)", output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #3582, making sure full system binaries are only launched with flags compatible with the full system.
Testing Done
Tested with PR #3507. First launched latest full system (blue) vs old full system 3507 (yellow) on master branch. Failed because yellow bots failed and old full system crashed.
Then launched same teams on the current branch. Yellow bots didn't crash and plays normally.
Also tested helper function
discover_supported_flagsby logging the set of available flags of different binaries. It logged the correct available flags.Resolved Issues
#3582
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue