Kill existing processes in binary context managers #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apeiros-46B
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
williamckha
approved these changes
Feb 7, 2026
williamckha
requested review from
a team,
GrayHoang and
itsarune
and removed request for
a team
GrayHoang
reviewed
Feb 7, 2026
| :param enable_realism: a argument (--enable_realism) that is going to be passed to er_force_simulator_main binary | ||
| """ | ||
| self.simulator_runtime_dir = simulator_runtime_dir | ||
| self.generic_command = [ |
Contributor
There was a problem hiding this comment.
should we have this defined twice across two separate files, or declare some constant that can be imported?
Member
There was a problem hiding this comment.
For something like this I'm fine with repeating ourselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a helper function to kill existing processes before starting the new instance in binary context managers
Testing Done
(not quite sure how to test this to be honest)
Resolved Issues
Resolves #3342
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue