Skip to content

fix: Update PR title prefix pattern in validating script #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ahzyuan merged 2 commits into from
Jun 25, 2025
Merged

fix: Update PR title prefix pattern in validating script #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecdc555
fix: update PR title prefix pattern in validating script to avoid mis…
Ahzyuan Jun 25, 2025
d9fd353
ci: fix compatibility test coverage comment feature
Ahzyuan Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/compatibility_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,10 @@ jobs:
if-no-files-found: error

- name: Pytest Coverage Comment
if: >-
matrix.python-version == '3.8' &&
github.event_name != 'workflow_dispatch'
if: matrix.python-version == '3.8'
uses: MishaKav/pytest-coverage-comment@v1
with:
issue-number: ${{ github.event.inputs.pr_number }}
title: Coverage Details on ${{ env.SHORT_OS }} under Python ${{ matrix.python-version }}
badge-title: Coverage
hide-badge: false
Expand Down
2 changes: 1 addition & 1 deletion misc/validate_pr_title.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ green_output() {

# ---------------------------------------------------------------------------------------------------

PATTERN='^(depr|perf|feat|fix|doc|test|ci|chore|build|refactor|revert)(\([^ ]+\))?\!?\s?: [A-Z].*[^\.\!\?,β€¦οΌοΌŸγ€‚οΌŒ ]$'
PATTERN='^(depr|perf|feat|fix|docs|test|ci|chore|build|refactor|revert)(\([^ ]+\))?\!?\s?: [A-Z].*[^\.\!\?,β€¦οΌοΌŸγ€‚οΌŒ ]$'

if [ $# -ne 1 ]; then
red_output "Error: There is and only needs one input, please enclose your input in '' and retry!"
Expand Down
Loading