Skip to content

Conversation

@Ahzyuan
Copy link
Member

@Ahzyuan Ahzyuan commented Jun 25, 2025

Prep Steps

Before we dive in, let's confirm you've unlocked all these steps

  • πŸ” I've checked for duplicate PRs (click to check)
  • πŸ“œ I've followed contribution guidelines
    • ✨ I've linted and formatted my code (how?)
    • πŸ”§ I've formatted the PR title appropriately (how?)
    • 🎯 I've targeted the master branch (how?)
    • πŸ‘ I've allowed maintainer edits on my branch (how? β†’ See step 6)
  • πŸ›‘οΈ I've added/updated tests to cover my changes if prossible (how?)
  • πŸ“ I've added/updated the documentation for any new logic introduced (how?)
  • ⏳ I understand @Ahzyuan has been busy lately and may need time to review. (we appreciate your patience!)

Type of changes

  • 🐞 Bug fix
  • 🌟 New feature
  • πŸ§ͺ Tests
  • πŸ— Refactoring
  • ⚑ Performance improvement
  • πŸ“– Documentation / docstrings
  • ↩️ Revert
  • 🧩 Other

Description

Purpose

This PR is to update the PR title prefix pattern in the validating script to avoid misjudgement. Additionally, fix some remainent bugs(the coverage comment feature) in the compatibility test workflow that was modifiied by PR #32.

Changes:

  • misc/validate_pr_title.sh: change doc to docs.
  • .github/workflows/compatibility_test.yml: remove unnecessary condition in coverage comment step and add specific argument to ensure the comments are issued in the target PR.

…judgment

- `misc/validate_pr_title.sh`: update `doc` to `docs` in `PATTERN`
@Ahzyuan Ahzyuan self-assigned this Jun 25, 2025
@github-actions github-actions bot added the bug-fix Fix something that isn't working as expected. label Jun 25, 2025
- Remove the unnecessary condition for issuing a PR comment
- Add `issue_number` to specify the PR to be commented
@Ahzyuan Ahzyuan merged commit caf8dcd into master Jun 25, 2025
1 check passed
@Ahzyuan Ahzyuan deleted the bugfix/update-pr-title-validate-pattern branch June 25, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fix something that isn't working as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants