Skip to content

Fix timing issue for updateSolutionServerProxies calls related to persist ID to UUID refactoring #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix timing issue for updateSolutionServerProxies calls related to persist ID to UUID refactoring #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312bcb7
Initial plan
Copilot Aug 21, 2025
83dff2f
Fix timing issue for updateSolutionServerProxies calls - move from So…
Copilot Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions com.servoy.eclipse.core/src/com/servoy/eclipse/core/ServoyModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3018,10 +3018,12 @@ else if (DataSourceUtils.VIEW_DATASOURCE.equals(tableNode.getServerName()))
{
changedEditing.put(child.getUUID(), editingPersist);
}
}

// TODO maybe here update used DB severs/tables here instead of sooner? or maybe both now and before... (there is another todo added in the same commit in SolutionDeserializer where it currently does that)

}

// Update solution server proxies after all persists are fully processed including deletions.
// This ensures the data source collection reflects the current state of the solution.
ModelUtils.updateSolutionServerProxies(solution, ApplicationServerRegistry.get().getDeveloperRepository());

// update the last modified time for the web client.
solution.updateLastModifiedTime();

Expand Down
10 changes: 5 additions & 5 deletions com.servoy.eclipse.model/src/com/servoy/eclipse/model/repository/SolutionDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,11 @@ public Object visit(IPersist o)
return CONTINUE_TRAVERSAL;
}

});
// TODO isn't this done too soon? I mean a deleted form from disk for example would not yet be removed from the solution at this point right? (see the other TODO that was added in ServoyModel in the same commit)
ModelUtils.updateSolutionServerProxies(solution, repository);
});

// ModelUtils.updateSolutionServerProxies() moved to ServoyModel.handleChangedFiles()
// for better timing - after all persists are fully processed including deletions
return changedFilesCopy; // what remains of the day
}
catch (Exception e)
Expand Down