Fix timing issue for updateSolutionServerProxies calls related to persist ID to UUID refactoring #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses timing issues in the
ModelUtils.updateSolutionServerProxies()calls that were identified as TODOs following the major persist ID → UUID refactoring in servoy-client (commit e899d29d89a0ec8c9b288550b1137c3163083acc).Problem
The
updateSolutionServerProxies()method was being called too early in the solution deserialization process, specifically inSolutionDeserializer.updateSolution(). At this point:DataSourceCollectorVisitorcould include stale data sources from deleted forms or miss new onesThe original TODOs highlighted this concern:
Solution
Moved the
updateSolutionServerProxies()call from the early deserialization phase to after all persist processing is complete:Removed from:
SolutionDeserializer.updateSolution()- called during file parsingAdded to:
ServoyModel.handleChangedFiles()- called after all persist updates and strayCats processingThis ensures that:
DataSourceCollectorVisitorsees the final, correct set of data sourcesFiles Changed
SolutionDeserializer.java: Removed premature call and added explanatory commentServoyModel.java: Added properly timed call with documentationImpact
This is a timing optimization with no functional changes to the API. The same server proxy functionality is maintained but with better reliability and consistency.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repo.eclipse.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/servoy-eclipse/servoy-eclipse org.codehaus.plexus.classworlds.launcher.Launcher clean compile -q(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.