Skip to content

Improve explicit imports hygiene #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Dec 30, 2025
Merged

Improve explicit imports hygiene #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
[compat]
Aqua = "0.8"
Distributions = "0.25"
ExplicitImports = "1.14.0"
JET = "0.9, 0.10, 0.11"
LogExpFunctions = "0.3"
Random = "1.10"
Expand All @@ -19,9 +20,10 @@ julia = "1.10"
[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Aqua", "Statistics", "Test", "Distributions", "JET"]
test = ["Aqua", "Statistics", "Test", "Distributions", "JET", "ExplicitImports"]
2 changes: 1 addition & 1 deletion src/PoissonRandom.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module PoissonRandom

using Random
using Random: Random, AbstractRNG, randexp
using LogExpFunctions: log1pmx

export pois_rand, PassthroughRNG
Expand Down
7 changes: 6 additions & 1 deletion test/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using PoissonRandom, Aqua, JET
using PoissonRandom, Aqua, JET, ExplicitImports
using Random

@testset "Aqua" begin
Expand Down Expand Up @@ -26,3 +26,8 @@ end
JET.@test_call target_modules = (PoissonRandom,) pois_rand(PassthroughRNG(), 10.0)
end
end

@testset "ExplicitImports" begin
@test check_no_implicit_imports(PoissonRandom) === nothing
@test check_no_stale_explicit_imports(PoissonRandom) === nothing
end
Loading