Improve explicit imports hygiene#61
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Dec 30, 2025
Merged
Conversation
- Made Random imports explicit: Random, AbstractRNG, randexp - Added ExplicitImports.jl to test dependencies - Added ExplicitImports tests to qa.jl test suite - All tests pass including new ExplicitImports checks This ensures the package follows best practices for explicit imports, preventing reliance on transitive dependencies and maintaining clear dependency relationships. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the package's explicit imports hygiene by:
Random,AbstractRNG,randexp) instead of relying onusing Randomwhich imports all exportsChanges Made
src/PoissonRandom.jl:3
Changed from:
using Randomto:
This explicitly lists what is imported from Random, preventing reliance on implicit/transitive imports.
Project.toml
test/qa.jl
using ExplicitImports@testset "ExplicitImports"with tests:check_no_implicit_imports(PoissonRandom)- ensures no implicit importscheck_no_stale_explicit_imports(PoissonRandom)- ensures no unused importsTest Results
All tests pass, including the new ExplicitImports tests:
Benefits
cc: @ChrisRackauckas
🤖 Generated with Claude Code