Skip to content

fix: host count for remediation #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swadeley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: host count for remediation #1505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions playwright/UI/AdvisoriesTests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
expect,
navigateToAdvisories,
getRowByName,
filterByName,
waitForTableLoad,
closePopupsIfExist,
} from 'test-utils';
Expand Down Expand Up @@ -68,6 +69,7 @@ test.describe('Advisories Tests', () => {
'true',
);
await waitForTableLoad(page);
await filterByName(page, system.name);
Copy link
Collaborator

@xbhouse xbhouse Feb 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a link handy to an example where this part of the test was failing? (nvm, i see your previous comment with a link in the other PR now 😃). the system filter is only on the systems tab, so that locator won't be found here 🤔

we are filtering by the system name already in the systems tab. there might be more than one system listed on that tab (maybe if they weren't cleaned up properly?), but since we're not checking the count anymore that should be fine

Copy link
Collaborator Author

@swadeley swadeley Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1491 (comment)

await expect(page.getByRole('row')).toHaveCount(2);

await page.getByRole('tab', { name: 'SystemsTab' }).click();
Expand Down
Loading