Skip to content

fix: host count for remediation#1505

Open
swadeley wants to merge 1 commit intoRedHatInsights:masterfrom
swadeley:swadeley/fix_host_count_planned_remediations
Open

fix: host count for remediation#1505
swadeley wants to merge 1 commit intoRedHatInsights:masterfrom
swadeley:swadeley/fix_host_count_planned_remediations

Conversation

@swadeley
Copy link
Collaborator

Description

Fix test to filter on system created for the test.

How to test the PR

'Check actions, systems, and execution history tabs' test passes.

Before the change

'Check actions, systems, and execution history tabs' test fails because many other systems from other tests are present in the table.

After the change

'Check actions, systems, and execution history tabs' test passes.

@swadeley swadeley requested a review from a team as a code owner February 16, 2026 07:44
@swadeley swadeley force-pushed the swadeley/fix_host_count_planned_remediations branch from eef7060 to 4bdcd0c Compare February 16, 2026 07:47
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.53%. Comparing base (cedc0ca) to head (4bdcd0c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   62.53%   62.53%           
=======================================
  Files         127      127           
  Lines        3310     3310           
  Branches      892      899    +7     
=======================================
  Hits         2070     2070           
  Misses       1120     1120           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TenSt TenSt self-assigned this Feb 16, 2026
'true',
);
await waitForTableLoad(page);
await filterByName(page, system.name);
Copy link
Collaborator

@xbhouse xbhouse Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a link handy to an example where this part of the test was failing? (nvm, i see your previous comment with a link in the other PR now 😃). the system filter is only on the systems tab, so that locator won't be found here 🤔

we are filtering by the system name already in the systems tab. there might be more than one system listed on that tab (maybe if they weren't cleaned up properly?), but since we're not checking the count anymore that should be fine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants