Skip to content

HMS-9726: Add filter type patch tests#1491

Open
swadeley wants to merge 1 commit intoRedHatInsights:masterfrom
swadeley:pr-9726
Open

HMS-9726: Add filter type patch tests#1491
swadeley wants to merge 1 commit intoRedHatInsights:masterfrom
swadeley:pr-9726

Conversation

@swadeley
Copy link
Collaborator

@swadeley swadeley commented Feb 9, 2026

Description

[QE] Add tests for filtering/searching in Patch

How to test the PR

Automated tests pass

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.53%. Comparing base (cedc0ca) to head (974ee5c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1491   +/-   ##
=======================================
  Coverage   62.53%   62.53%           
=======================================
  Files         127      127           
  Lines        3310     3310           
  Branches      892      899    +7     
=======================================
  Hits         2070     2070           
  Misses       1120     1120           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@swadeley swadeley force-pushed the pr-9726 branch 3 times, most recently from dc45675 to 4140157 Compare February 10, 2026 13:05
@xbhouse xbhouse self-assigned this Feb 10, 2026
await expect(page.getByRole('button', { name: 'Conditional filter toggle' })).toBeVisible();
});

test('Filter types on Systems page', async ({ page, systems }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the filtered data for systems could be verified for most of these (maybe excluding Tags?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, improvements made, thank you

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, by this comment i meant to verify the data displayed is expected when filtering in the following steps (similar to what you've done for advisories and packages).

to test the tags filter, i think this would involve adding a new system archive with a tag (found some docs here that might be helpful)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, will get to this after PTO

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, thank you for picking this up ❤️ reach out when you get back if you need any help

Support exact match in filter helper

Use exact match for menu items

https://issues.redhat.com/browse/HMS-9726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants