P2897R4: aligned_accessor #465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update based on further discussion with David Sankel.
* Rename `is_checkably_valid` to `detectably_invalid`
(with inverted return value)
* Ask LEWG to consider the alternative design that makes
`is_sufficiently_aligned` a nonmember function in `<bit>`
instead of a member function of `aligned_accessor`,
while LWG review of R2 proceeds concurrently
* P2389R2 was voted into the Working Draft at St. Louis,
so replace use of `dextents` in examples with `dims`.
* Minor formatting and non-wording fixes
Add non-wording section explaining why `aligned_accessor` has no `explicit` constructor from less to more alignment.
mhoemmen
force-pushed
the
aligned_accessor-R4
branch
2 times, most recently
from
7d8eea5 to
38b9433
Compare
* Make is_sufficiently_aligned a nonmember function (in the wording) * Fix nonwording sections accordingly * Minor correction in Example in Wording * Update implementation Compiler Explorer link and source code (Appendix B)
mhoemmen
force-pushed
the
aligned_accessor-R4
branch
from
0ca4482 to
081271e
Compare
* Improve Godbolt implementation I'm submitting P2897R4.html as P2897R4 (aligned_accessor).
mhoemmen
force-pushed
the
aligned_accessor-R4
branch
from
535e3b6 to
2dd224f
Compare
Contributor
Author
|
Superseded by PR #466 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per LEWG chair request, make
is_sufficiently_aligneda nonmember function.Please merge PR #463 first; thanks!