Expose internal packages for external consumption #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 21434209874Details
💛 - Coveralls |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change makes the nvdevices and nvmodules packages public to allow this functionality to be consumed by other clients directly. These include the mig-manager and the gpu-operator. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
expose-tooling
branch
from
43e04b0 to
767e0b3
Compare
elezar
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes exposes the following internal package:
internal/configasapi/config/v1internal/lookupaspkg/lookupinternal/nvdevicesandinternal/nvmodulesasinternal/system/nv{devices,modules}(see Make systems/nvdevices package public #1372)This allows these packages to be imported into other projects where these are required.
Note that it make also make sense to move
lookuptogo-nvlibinstead as in NVIDIA/go-nvlib#84